content/browser/renderer_host/media/media_stream_dispatcher_host.cc - Issue 10829190: Resolve the problems where we can leak the system tray UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_dispatcher_host.cc

Issue 10829190: Resolve the problems where we can leak the system tray UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed more relevant problems, ready for review now. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_device_settings.cc ('K') | « content/browser/renderer_host/media/media_stream_device_settings.cc ('k') | content/browser/renderer_host/media/media_stream_manager.h » ('j') | content/browser/renderer_host/media/media_stream_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_dispatcher_host.cc

diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host.cc b/content/browser/renderer_host/media/media_stream_dispatcher_host.cc

index fb817b9cf8a738dceeb3c5c6857e376457677e26..855ae75cbe22e2a2c5230f9680d45ccbfedcf6cf 100644

--- a/content/browser/renderer_host/media/media_stream_dispatcher_host.cc

+++ b/content/browser/renderer_host/media/media_stream_dispatcher_host.cc

@@ -143,9 +143,7 @@ void MediaStreamDispatcherHost::OnChannelClosing() {

BrowserMessageFilter::OnChannelClosing();

DVLOG(1) << "MediaStreamDispatcherHost::OnChannelClosing";

- // Since the IPC channel is gone, cancel pending requests and close all

- // requested VideoCaptureDevices.

- GetManager()->CancelRequests(this);

+ // Since the IPC channel is gone, close all requesting/requested streams.

for (StreamMap::iterator it = streams_.begin();

it != streams_.end();

it++) {