Resolve the problems where we can leak the system tray UI

content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "content/browser/browser_thread_impl.h"
 #include "content/browser/renderer_host/media/audio_input_device_manager.h"
@@ skipping 303 matching lines @@
 }
 
 TEST_F(MediaStreamDispatcherHostTest, FailDevice) {
   StreamOptions options(false, true);
 
   EXPECT_CALL(*host_, GetMediaObserver())
       .WillRepeatedly(Return(media_observer_.get()));
   EXPECT_CALL(*host_, OnStreamGenerated(kRenderId, kPageRequestId, 0, 1));
   host_->OnGenerateStream(kPageRequestId, options);
   EXPECT_CALL(*media_observer_.get(), OnCaptureDevicesOpened(_, _, _));
+  EXPECT_CALL(*media_observer_.get(), OnCaptureDevicesClosed(_, _, _));

[perkj_chrome, 2012/08/10 07:09:31]

Move this to just before OnStopGeneratedStream

[no longer working on chromium, 2012/08/10 11:50:56]

Done.

   WaitForResult();
   std::string label =  host_->label_;
 
   EXPECT_EQ(host_->audio_devices_.size(), 0u);
   EXPECT_EQ(host_->video_devices_.size(), 1u);
   EXPECT_EQ(host_->NumberOfStreams(), 1u);
 
   EXPECT_CALL(*host_, OnVideoDeviceFailed(kRenderId, 0));
   int session_id = host_->video_devices_[0].session_id;
   media_stream_manager_->video_capture_manager()->Error(session_id);
   WaitForResult();
   EXPECT_EQ(host_->video_devices_.size(), 0u);
   EXPECT_EQ(host_->NumberOfStreams(), 1u);
 
   // TODO(perkj): test audio device failure?
 
   host_->OnStopGeneratedStream(label);
   EXPECT_EQ(host_->NumberOfStreams(), 0u);
 }
 
+TEST_F(MediaStreamDispatcherHostTest, CancelPendingStreamsOnChannelClosing) {
+  StreamOptions options(false, true);
+
+  EXPECT_CALL(*host_, GetMediaObserver())
+      .WillRepeatedly(Return(media_observer_.get()));
+
+  // Create multiple GenerateStream requests.
+  size_t streams = 5;
+  for (size_t i = 1; i <= streams; ++i) {
+    host_->OnGenerateStream(kPageRequestId + i, options);
+    EXPECT_EQ(host_->NumberOfStreams(), i);
+  }
+
+  // Calling OnChannelClosing() to cancel all the pending requests.
+  host_->OnChannelClosing();
+
+  // Streams should have been cleaned up.
+  EXPECT_EQ(host_->NumberOfStreams(), 0u);
+}
+
+TEST_F(MediaStreamDispatcherHostTest, StopAllStreamsOnChannelClosing) {
+  StreamOptions options(false, true);
+
+  EXPECT_CALL(*host_, GetMediaObserver())
+      .WillRepeatedly(Return(media_observer_.get()));
+
+  // Create first group of streams.
+  size_t generated_streams = 3;
+  for (size_t i = 0; i < generated_streams; ++i) {
+    EXPECT_CALL(*host_, OnStreamGenerated(kRenderId, kPageRequestId + i, 0, 1));
+    host_->OnGenerateStream(kPageRequestId + i, options);
+  }
+  EXPECT_EQ(host_->NumberOfStreams(), generated_streams);
+  EXPECT_CALL(*media_observer_.get(), OnCaptureDevicesOpened(_, _, _))
+      .Times(3);
+  EXPECT_CALL(*media_observer_.get(), OnCaptureDevicesClosed(_, _, _))

[perkj_chrome, 2012/08/10 07:09:31]

Move this expect to just before host->OnChannelClosing.

[no longer working on chromium, 2012/08/10 11:50:56]

Done.

+      .Times(3);
+  // Wait until the streams are all generated.
+  WaitForResult();
+
+  // Create second group of streams.
+  size_t pending_streams = 3;

[perkj_chrome, 2012/08/10 07:09:31]

No need to test CancelPendingStreams again. You have a test above for that.

[no longer working on chromium, 2012/08/10 11:50:56]

Done.

+  for (size_t i = 1; i <= pending_streams; ++i) {
+    host_->OnGenerateStream(kPageRequestId + generated_streams + i, options);
+  }
+  EXPECT_EQ(host_->NumberOfStreams(), pending_streams + generated_streams);
+
+  // Calling OnChannelClosing() to cancel all the pending/generated streams.
+  host_->OnChannelClosing();
+
+  // Streams should have been cleaned up.
+  EXPECT_EQ(host_->NumberOfStreams(), 0u);
+}
+
 };  // namespace media_stream