Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: chrome/browser/ui/panels/panel.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/panel.cc
diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc
index ac995394bfeebeb01ec39b4da3c441bad5c0c070..68c9e1cc93bb79262fd0b5cdb5831ba29e706404 100644
--- a/chrome/browser/ui/panels/panel.cc
+++ b/chrome/browser/ui/panels/panel.cc
@@ -37,6 +37,10 @@
using content::RenderViewHost;
using content::UserMetricsAction;
+namespace extensions {
+class Extension;
+}
+
namespace panel_internal {
class PanelExtensionWindowController : public extensions::WindowController {
@@ -47,7 +51,8 @@ class PanelExtensionWindowController : public extensions::WindowController {
// Overridden from extensions::WindowController.
virtual int GetWindowId() const OVERRIDE;
virtual std::string GetWindowTypeText() const OVERRIDE;
- virtual base::DictionaryValue* CreateWindowValueWithTabs() const OVERRIDE;
+ virtual base::DictionaryValue* CreateWindowValueWithTabs(
+ const extensions::Extension* extension) const OVERRIDE;
virtual bool CanClose(Reason* reason) const OVERRIDE;
virtual void SetFullscreenMode(bool is_fullscreen,
const GURL& extension_url) const OVERRIDE;
@@ -79,7 +84,8 @@ std::string PanelExtensionWindowController::GetWindowTypeText() const {
}
base::DictionaryValue*
-PanelExtensionWindowController::CreateWindowValueWithTabs() const {
+PanelExtensionWindowController::CreateWindowValueWithTabs(
+ const extensions::Extension* extension) const {
return CreateWindowValue();
}

Powered by Google App Engine
This is Rietveld 408576698