Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/extensions/extension_unittest.cc

Issue 10829186: Tabs API is usable without tabs permission. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fixed failing browser/api tests Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/tabs/tabs.cc ('K') | « chrome/browser/extensions/extension_tabs_apitest.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | chrome/common/extensions/permissions/permission_set.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_unittest.cc
diff --git a/chrome/common/extensions/extension_unittest.cc b/chrome/common/extensions/extension_unittest.cc
index 6ffccba2a5a0fcd846a8aec801a23cc7e1294abd..d1260c5b4c75d03a4a359a508ee7c4f86743f2b2 100644
--- a/chrome/common/extensions/extension_unittest.cc
+++ b/chrome/common/extensions/extension_unittest.cc
@@ -549,7 +549,6 @@ TEST(ExtensionTest, ApiPermissions) {
{ "bookmarks", false },
{ "cookies", false },
{ "history", false },
- { "tabs.onUpdated", false },
// Make sure we find the module name after stripping '.' and '/'.
{ "browserAction/abcd/onClick", true },
{ "browserAction.abcd.onClick", true },
@@ -558,7 +557,8 @@ TEST(ExtensionTest, ApiPermissions) {
{ "tabs.onRemoved", true},
{ "tabs.remove", true},
{ "tabs.update", true},
- { "tabs.getSelected", false},
+ { "tabs.getSelected", true},
+ { "tabs.onUpdated", true },
// Test getPermissionWarnings functions. Only one requires permissions.
{ "management.getPermissionWarningsById", false },
{ "management.getPermissionWarningsByManifest", true },
« chrome/browser/extensions/api/tabs/tabs.cc ('K') | « chrome/browser/extensions/extension_tabs_apitest.cc ('k') | chrome/common/extensions/permissions/permission_set.cc » ('j') | chrome/common/extensions/permissions/permission_set.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698