Cocoa: Show OAuth issues in extension install dialog

chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/compiler_specific.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
@@ skipping 120 matching lines @@
   // Check all the controls.
   // Make sure everything is non-nil, and that the fields that are
   // auto-translated don't start with a caret (that would indicate that they
   // were not translated).
   EXPECT_TRUE([controller iconView] != nil);
   EXPECT_TRUE([[controller iconView] image] != nil);
 
   EXPECT_TRUE([controller titleField] != nil);
   EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
 
-  EXPECT_TRUE([controller subtitleField] != nil);
-  EXPECT_NE(0u, [[[controller subtitleField] stringValue] length]);
-  EXPECT_NE('^', [[[controller subtitleField] stringValue] characterAtIndex:0]);
-
-  EXPECT_TRUE([controller warningsField] != nil);
-  EXPECT_NSEQ([[controller warningsField] stringValue],
+  NSOutlineView* outlineView = [controller outlineView];
+  EXPECT_TRUE(outlineView != nil);
+  EXPECT_EQ(2, [outlineView numberOfRows]);
+  EXPECT_NSEQ([[outlineView dataSource] outlineView:outlineView
+                          objectValueForTableColumn:nil
+                                             byItem:[outlineView itemAtRow:1]],
               base::SysUTF16ToNSString(prompt.GetPermission(0)));
 
   EXPECT_TRUE([controller cancelButton] != nil);
   EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
   EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller okButton] != nil);
   EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
@@ skipping 67 matching lines @@
                               prompt:two_warnings_prompt]);
 
   [controller2 window];  // force nib load
 
   // Test control positioning. We don't test exact positioning because we don't
   // want this to depend on string details and localization. But we do know the
   // relative effect that adding a second warning should have on the layout.
   ASSERT_LT([[controller1 window] frame].size.height,
             [[controller2 window] frame].size.height);
 
-  ASSERT_LT([[controller1 warningsField] frame].size.height,
-            [[controller2 warningsField] frame].size.height);
-
-  ASSERT_LT([[controller1 subtitleField] frame].origin.y,
-            [[controller2 subtitleField] frame].origin.y);
+  ASSERT_LT([[controller1 outlineView] frame].size.height,
+            [[controller2 outlineView] frame].size.height);
 
   ASSERT_LT([[controller1 titleField] frame].origin.y,
             [[controller2 titleField] frame].origin.y);
 }
 
 // Test that we can load the skinny prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallDialogControllerTest, BasicsSkinny) {
   MockExtensionInstallPromptDelegate delegate;
 
@@ skipping 25 matching lines @@
   EXPECT_NE(0u, [[[controller titleField] stringValue] length]);
 
   EXPECT_TRUE([controller cancelButton] != nil);
   EXPECT_NE(0u, [[[controller cancelButton] stringValue] length]);
   EXPECT_NE('^', [[[controller cancelButton] stringValue] characterAtIndex:0]);
 
   EXPECT_TRUE([controller okButton] != nil);
   EXPECT_NE(0u, [[[controller okButton] stringValue] length]);
   EXPECT_NE('^', [[[controller okButton] stringValue] characterAtIndex:0]);
 
-  EXPECT_TRUE([controller subtitleField] == nil);
-  EXPECT_TRUE([controller warningsField] == nil);
+  EXPECT_TRUE([controller outlineView] == nil);
 }
 
 
 // Test that we can load the inline prompt correctly, and that the outlets are
 // are hooked up.
 TEST_F(ExtensionInstallDialogControllerTest, BasicsInline) {
   MockExtensionInstallPromptDelegate delegate;
 
   // No warnings should trigger skinny prompt.
   ExtensionInstallPrompt::Prompt inline_prompt(
@@ skipping 33 matching lines @@
   EXPECT_EQ(5u, [[[controller ratingStars] subviews] count]);
 
   EXPECT_TRUE([controller ratingCountField] != nil);
   EXPECT_NE(0u, [[[controller ratingCountField] stringValue] length]);
 
   EXPECT_TRUE([controller userCountField] != nil);
   EXPECT_NE(0u, [[[controller userCountField] stringValue] length]);
 
   // Though we have no permissions warnings, these should still be hooked up,
   // just invisible.
-  EXPECT_TRUE([controller subtitleField] != nil);
-  EXPECT_TRUE([[controller subtitleField] isHidden]);
-  EXPECT_TRUE([controller warningsField] != nil);
-  EXPECT_TRUE([[controller warningsField] isHidden]);
+  EXPECT_TRUE([controller outlineView] != nil);
+  EXPECT_TRUE([[[controller outlineView] enclosingScrollView] isHidden]);
   EXPECT_TRUE([controller warningsSeparator] != nil);
   EXPECT_TRUE([[controller warningsSeparator] isHidden]);
 }
+
+TEST_F(ExtensionInstallDialogControllerTest, OAuthIssues) {
+  MockExtensionInstallPromptDelegate delegate;
+
+  ExtensionInstallPrompt::Prompt prompt(
+      ExtensionInstallPrompt::INSTALL_PROMPT);
+  std::vector<string16> permissions;
+  permissions.push_back(UTF8ToUTF16("warning 1"));
+  prompt.SetPermissions(permissions);
+  IssueAdviceInfoEntry issue;
+  issue.description = UTF8ToUTF16("issue description 1");
+  issue.details.push_back(UTF8ToUTF16("issue detail 1"));
+  IssueAdviceInfo issues;
+  issues.push_back(issue);
+  prompt.SetOAuthIssueAdvice(issues);
+  prompt.set_extension(extension_.get());
+  prompt.set_icon(icon_);
+
+  scoped_nsobject<ExtensionInstallDialogController>
+  controller([[ExtensionInstallDialogController alloc]
+               initWithParentWindow:test_window()
+                          navigator:browser()
+                           delegate:&delegate
+                             prompt:prompt]);
+
+  [controller window];  // force nib load
+  NSOutlineView* outlineView = [controller outlineView];
+  EXPECT_TRUE(outlineView != nil);
+  EXPECT_EQ(4, [outlineView numberOfRows]);
+  EXPECT_NSEQ([[outlineView dataSource] outlineView:outlineView
+                          objectValueForTableColumn:nil
+                                             byItem:[outlineView itemAtRow:3]],
+              base::SysUTF16ToNSString(prompt.GetOAuthIssue(0).description));
+}