Make MediaFileUtil run on thread pool.

webkit/fileapi/local_file_system_operation.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/local_file_system_operation.h"
 
 #include "base/bind.h"
 #include "base/sequenced_task_runner.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "net/base/escape.h"
 #include "net/url_request/url_request_context.h"
 #include "webkit/blob/shareable_file_reference.h"
 #include "webkit/fileapi/file_system_context.h"
 #include "webkit/fileapi/file_system_file_util_proxy.h"
 #include "webkit/fileapi/file_system_mount_point_provider.h"
 #include "webkit/fileapi/file_system_operation_context.h"
 #include "webkit/fileapi/file_system_quota_util.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/file_system_url.h"
 #include "webkit/fileapi/file_system_util.h"
 #include "webkit/fileapi/file_writer_delegate.h"
 #include "webkit/fileapi/sandbox_file_stream_writer.h"
 #include "webkit/quota/quota_manager.h"
 #include "webkit/quota/quota_types.h"
 
 namespace fileapi {
 
+namespace {
+
+bool IsMediaFileSystemType(FileSystemType type) {
+  return type == kFileSystemTypeNativeMedia ||
+      type == kFileSystemTypeDeviceMedia;
+}
+
+// TODO(tzik): Cleanup this.
+base::PlatformFileError IsCompatibleFileSystemPair(FileSystemType src_type,

[kinuko, 2012/08/03 23:13:39]

nit: IsCrossOperationAllowed(src, dest) ...?  Also if this method is named
'IsFoo' I think this should just return boolean.

Please add comments.
"If two types are supposed to run on different task runners we should not allow
cross FileUtil operations at this layer."

[tzik, 2012/08/04 00:24:21]

Done.

+                                                   FileSystemType dest_type) {
+  return IsMediaFileSystemType(src_type) == IsMediaFileSystemType(dest_type) ?
+      base::PLATFORM_FILE_OK :
+      base::PLATFORM_FILE_ERROR_INVALID_OPERATION;
+

[kinuko, 2012/08/03 23:13:39]

nit: extra empty line

[tzik, 2012/08/04 00:24:21]

Done.

+}
+
+}  // namespace
+
 class LocalFileSystemOperation::ScopedQuotaNotifier {
  public:
   ScopedQuotaNotifier(FileSystemContext* context,
                       const GURL& origin_url,
                       FileSystemType type);
   ~ScopedQuotaNotifier();
 
  private:
   // Not owned; owned by the owner of this instance
   // (i.e. LocalFileSystemOperation).
@@ skipping 70 matching lines @@
 }
 
 void LocalFileSystemOperation::Copy(const FileSystemURL& src_url,
                                     const FileSystemURL& dest_url,
                                     const StatusCallback& callback) {
   DCHECK(SetPendingOperationType(kOperationCopy));
 
   base::PlatformFileError result = SetUp(src_url, &src_util_, SETUP_FOR_READ);
   if (result == base::PLATFORM_FILE_OK)
     result = SetUp(dest_url, &dest_util_, SETUP_FOR_CREATE);
+  if (result == base::PLATFORM_FILE_OK)
+    result = IsCompatibleFileSystemPair(src_url.type(), dest_url.type());
   if (result != base::PLATFORM_FILE_OK) {
     callback.Run(result);
     delete this;
     return;
   }
 
   GetUsageAndQuotaThenRunTask(
       dest_url,
       base::Bind(&LocalFileSystemOperation::DoCopy,
                  base::Unretained(this), src_url, dest_url, callback),
       base::Bind(callback, base::PLATFORM_FILE_ERROR_FAILED));
 }
 
 void LocalFileSystemOperation::Move(const FileSystemURL& src_url,
                                     const FileSystemURL& dest_url,
                                     const StatusCallback& callback) {
   DCHECK(SetPendingOperationType(kOperationMove));
   scoped_ptr<LocalFileSystemOperation> deleter(this);
 
   base::PlatformFileError result = SetUp(src_url, &src_util_, SETUP_FOR_WRITE);
   if (result == base::PLATFORM_FILE_OK)
     result = SetUp(dest_url, &dest_util_, SETUP_FOR_CREATE);
+  if (result == base::PLATFORM_FILE_OK)
+    result = IsCompatibleFileSystemPair(src_url.type(), dest_url.type());
   if (result != base::PLATFORM_FILE_OK) {
     callback.Run(result);
     return;
   }
 
   // Temporarily disables cross-filesystem move for sandbox filesystems.
   // TODO(kinuko,tzik,kinaba): This special handling must be removed once
   // we support saner cross-filesystem operation.
   // (See http://crbug.com/130055)
   if (src_url.type() != dest_url.type() &&
@@ skipping 581 matching lines @@
 }
 
 bool LocalFileSystemOperation::SetPendingOperationType(OperationType type) {
   if (pending_operation_ != kOperationNone)
     return false;
   pending_operation_ = type;
   return true;
 }
 
 }  // namespace fileapi