chrome/browser/chromeos/contacts/contact_test_util.cc - Issue 10829144: contacts: Add GoogleContactStore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/contacts/contact_test_util.cc

Issue 10829144: contacts: Add GoogleContactStore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix leaked contacts in GoogleContactStore::MergeContacts() Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/contacts/contact_test_util.cc

diff --git a/chrome/browser/chromeos/contacts/contact_test_util.cc b/chrome/browser/chromeos/contacts/contact_test_util.cc

index a7186fb518247b5aeb358189d3cdfb214cc88a5f..9a1ceae7f6d0ae43dd3723191db6327add075776 100644

--- a/chrome/browser/chromeos/contacts/contact_test_util.cc

+++ b/chrome/browser/chromeos/contacts/contact_test_util.cc

@@ -138,11 +138,8 @@ void CopyContacts(const ContactPointers& source,

ScopedVector<Contact>* dest) {

DCHECK(dest);

dest->clear();

- for (size_t i = 0; i < source.size(); ++i) {

- Contact* contact = new Contact;

- *contact = *source[i];

- dest->push_back(contact);

- }

+ for (size_t i = 0; i < source.size(); ++i)

+ dest->push_back(new Contact(*source[i]));

}

void CopyContacts(const ScopedVector<Contact>& source,