Disable the managed storage API behind a flag for M22.

Disable the managed storage API behind a flag for M22.

BUG=108992
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149837

[Joao da Silva, 2012-08-02 11:50:42]

The policy side for this work isn't completely ready for the mac and chromeos,
so this feature shouldn't be enabled for M22.

@kalman: please review, thanks!

@mnissler: FYI

[not at google - send to devlin, 2012-08-02 12:26:54]

There is probably way to do this with our Feature system, but not sure. Command
line flag is fine I think (and I presume you don't want it in about:flags?
that's a question for you guys).

You will need to add nodoc:true to the storage docs, though.

[Joao da Silva, 2012-08-02 13:36:17]

On 2012/08/02 12:26:54, kalman wrote:
> There is probably way to do this with our Feature system, but not sure.
Command
> line flag is fine I think (and I presume you don't want it in about:flags?
> that's a question for you guys).

The switch is meant to allow proceeding with development. This feature isn't
meant to be launched yet to users, and shouldn't be discoverable in about:flags.

> 
> You will need to add nodoc:true to the storage docs, though.

Of course, done. PTAL.

[not at google - send to devlin, 2012-08-02 13:38:42]

lgtm

[commit-bot: I haz the power, 2012-08-02 15:43:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10829142/1006

[commit-bot: I haz the power, 2012-08-02 15:43:58]

Presubmit check for 10829142-1006 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 4.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Joao da Silva, 2012-08-02 15:45:28]

@thakis: please review the new switch :-) thanks!

[Nico, 2012-08-02 15:56:10]

lgtm

http://codereview.chromium.org/10829142/diff/1006/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10829142/diff/1006/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:567: // flag can be used to enable it until it
is released.
nit: Add a TODO to remove once bug 108992 is fixed

[Joao da Silva, 2012-08-03 08:23:31]

http://codereview.chromium.org/10829142/diff/1006/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/10829142/diff/1006/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:567: // flag can be used to enable it until it
is released.
On 2012/08/02 15:56:10, Nico wrote:
> nit: Add a TODO to remove once bug 108992 is fixed

Done.

[commit-bot: I haz the power, 2012-08-03 08:23:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10829142/13001

[commit-bot: I haz the power, 2012-08-03 11:28:37]

Change committed as 149837