Adding RevokeFileSystemByPath

webkit/fileapi/isolated_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FILEAPI_ISOLATED_CONTEXT_H_
 #define WEBKIT_FILEAPI_ISOLATED_CONTEXT_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 83 matching lines @@
   // Registers a new isolated filesystem for a given |path| of filesystem
   // |type| filesystem and returns a new filesystem ID.
   // |path| must be an absolute path which has no parent references ('..').
   // If |register_name| is non-null and has non-empty string the path is
   // registered as the given |register_name|, otherwise it is populated
   // with the name internally assigned to the path.
   std::string RegisterFileSystemForPath(FileSystemType type,
                                         const FilePath& path,
                                         std::string* register_name);
 
-  // Revokes filesystem specified by the given filesystem_id.
+  // Revokes all filesystem(s) registerred for the given path.

[kmadhusu, 2012/08/02 20:07:03]

nit: typo "registered"

[kinuko, 2012/08/02 20:36:22]

Done.

+  // This is assumed to be called when the registerred path becomes
+  // globally invalid, e.g. when a device for the path is detached.
+  //
   // Note that this revokes the filesystem no matter how many references it has.
-  // It is ok to call this on the filesystem that has been already deleted
-  // (if its reference count had reached 0).
-  void RevokeFileSystem(const std::string& filesystem_id);
+  // It is ok to call this for the path that has no associated filesystems.
+  // Note that this only works for the filesystems registered by
+  // |RegisterFileSystemForPath|.
+  void RevokeFileSystemByPath(const FilePath& path);
 
   // Adds a reference to a filesystem specified by the given filesystem_id.
   void AddReference(const std::string& filesystem_id);
 
   // Removes a reference to a filesystem specified by the given filesystem_id.
   // If the reference count reaches 0 the isolated context gets destroyed.
   // It is ok to call this on the filesystem that has been already deleted
-  // (e.g. by RevokeFileSystem).
+  // (e.g. by RevokeFileSystemByPath).
   void RemoveReference(const std::string& filesystem_id);
 
   // Cracks the given |virtual_path| (which should look like
   // "/<filesystem_id>/<registered_name>/<relative_path>") and populates
   // the |filesystem_id| and |path| if the embedded <filesystem_id>
   // is registerred to this context.  |root_path| is also populated to have
   // the registered root (toplevel) file info for the |virtual_path|.
   //
   // Returns false if the given virtual_path or the cracked filesystem_id
   // is not valid.
@@ skipping 22 matching lines @@
   // Returns the virtual root path that looks like /<filesystem_id>.
   FilePath CreateVirtualRootPath(const std::string& filesystem_id) const;
 
  private:
   friend struct base::DefaultLazyInstanceTraits<IsolatedContext>;
 
   // Represents each isolated file system instance.
   class Instance {
    public:
     Instance(FileSystemType type, const FileInfo& file_info);
-    explicit Instance(const std::set<FileInfo>& dragged_files);
+    explicit Instance(FileSystemType type, const std::set<FileInfo>& files);
     ~Instance();
 
     FileSystemType type() const { return type_; }
     const FileInfo& file_info() const { return file_info_; }
-    const std::set<FileInfo>& dragged_files() const { return dragged_files_; }
+    const std::set<FileInfo>& files() const { return files_; }
     int ref_counts() const { return ref_counts_; }
 
     void AddRef() { ++ref_counts_; }
     void RemoveRef() { --ref_counts_; }
 
-    bool ResolvePathForName(const std::string& name, FilePath* path);
+    bool ResolvePathForName(const std::string& name, FilePath* path) const;
+
+    bool IsSinglePathInstance() const {
+      return instance_type_ == kSinglePathInstance;
+    }
 
    private:
+    enum InstanceType {
+      kSinglePathInstance,
+      kMultiplePathInstance,

[kmadhusu, 2012/08/02 20:03:59]

nit: Can you please more comments on when we will have multiple path instance?

[kinuko, 2012/08/02 20:36:22]

I removed this type but instead added
IsSinglePathIsolatedFileSystem()
internal function and DCHECKs.

+    };
+
     const FileSystemType type_;
+    const InstanceType instance_type_;
+
+    // For single-path instance.
     const FileInfo file_info_;
 
-    // For dragged file system.
-    const std::set<FileInfo> dragged_files_;
+    // For multiple-path instance (e.g. dragged file system).
+    const std::set<FileInfo> files_;
 
     // Reference counts. Note that an isolated filesystem is created with ref==0
     // and will get deleted when the ref count reaches <=0.
     int ref_counts_;
 
     DISALLOW_COPY_AND_ASSIGN(Instance);
   };
 
   typedef std::map<std::string, Instance*> IDToInstance;
 
+  // Reverse map from registerred path to IDs.
+  typedef std::map<FilePath, std::set<std::string> > PathToID;
+
   // Obtain an instance of this class via GetInstance().
   IsolatedContext();
   ~IsolatedContext();
 
   // Returns a new filesystem_id.  Called with lock.
   std::string GetNewFileSystemId() const;
 
   // This lock needs to be obtained when accessing the instance_map_.
   mutable base::Lock lock_;
 
   IDToInstance instance_map_;
+  PathToID path_to_id_map_;
 
   DISALLOW_COPY_AND_ASSIGN(IsolatedContext);
 };
 
 }  // namespace fileapi
 
 #endif  // WEBKIT_FILEAPI_ISOLATED_CONTEXT_H_