Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10829136: Adding RevokeFileSystemByPath (Closed)

Created:
8 years, 4 months ago by kinuko
Modified:
8 years, 4 months ago
Reviewers:
kmadhusu, tzik
CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org, kmadhusu
Visibility:
Public.

Description

Adding RevokeFileSystemByPath so that we can make sure we invalidate all file systems associated to a given path (e.g. for a detached device) BUG=none TEST=IsolatedContextTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149732

Patch Set 1 : #

Total comments: 4

Patch Set 2 : removed instance_type_, added more comments #

Patch Set 3 : #

Patch Set 4 : build fix!! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -43 lines) Patch
M chrome/browser/media_gallery/media_file_system_registry.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webkit/fileapi/isolated_context.h View 1 2 6 chunks +33 lines, -12 lines 0 comments Download
M webkit/fileapi/isolated_context.cc View 1 2 3 7 chunks +76 lines, -24 lines 0 comments Download
M webkit/fileapi/isolated_context_unittest.cc View 3 chunks +28 lines, -5 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
It's still a bit rough... but could you take a look?
8 years, 4 months ago (2012-08-02 01:24:04 UTC) #1
tzik
On 2012/08/02 01:24:04, kinuko wrote: > It's still a bit rough... but could you take ...
8 years, 4 months ago (2012-08-02 17:58:28 UTC) #2
tzik
lgtm
8 years, 4 months ago (2012-08-02 18:35:14 UTC) #3
kmadhusu
http://codereview.chromium.org/10829136/diff/2001/webkit/fileapi/isolated_context.h File webkit/fileapi/isolated_context.h (right): http://codereview.chromium.org/10829136/diff/2001/webkit/fileapi/isolated_context.h#newcode183 webkit/fileapi/isolated_context.h:183: kMultiplePathInstance, nit: Can you please more comments on when ...
8 years, 4 months ago (2012-08-02 20:03:59 UTC) #4
kmadhusu
http://codereview.chromium.org/10829136/diff/2001/webkit/fileapi/isolated_context.h File webkit/fileapi/isolated_context.h (right): http://codereview.chromium.org/10829136/diff/2001/webkit/fileapi/isolated_context.h#newcode104 webkit/fileapi/isolated_context.h:104: // Revokes all filesystem(s) registerred for the given path. ...
8 years, 4 months ago (2012-08-02 20:07:03 UTC) #5
kinuko
http://codereview.chromium.org/10829136/diff/2001/webkit/fileapi/isolated_context.h File webkit/fileapi/isolated_context.h (right): http://codereview.chromium.org/10829136/diff/2001/webkit/fileapi/isolated_context.h#newcode104 webkit/fileapi/isolated_context.h:104: // Revokes all filesystem(s) registerred for the given path. ...
8 years, 4 months ago (2012-08-02 20:36:22 UTC) #6
kmadhusu
8 years, 4 months ago (2012-08-02 21:26:21 UTC) #7 
lgtm. Thanks.

Powered by Google App Engine
This is Rietveld 408576698