Refactoring NTP5: new implementation of TilePage and MostVisitedPage (which now inherits from Thumb…

chrome/browser/resources/ntp_search/new_tab.css

Index: chrome/browser/resources/ntp_search/new_tab.css
diff --git a/chrome/browser/resources/ntp_search/new_tab.css b/chrome/browser/resources/ntp_search/new_tab.css
new file mode 100644
index 0000000000000000000000000000000000000000..f2e19b6383f4c8768062b0906c9f608088dce8bb
--- /dev/null
+++ b/chrome/browser/resources/ntp_search/new_tab.css
@@ -0,0 +1,383 @@
+/* Copyright (c) 2012 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file. */
+
+/* =========================================================================
+   TODO(pedrosimonetti): Work around
+   ========================================================================= */
+
+body > center {
+  height: 100%;
+  min-height: 540px;
+  position: relative;
+}
+
+#card-slider-frame {
+  bottom: 0 !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+  position: absolute;
+  top: inherit !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+}
+
+#page-switcher-start,
+#page-switcher-end {
+  display: none;
+}
+
+#footer,
+#footer-border,
+#footer-content {
+  display: none;
+}
+
+.tile-page {
+  display: block;
+}
+
+.tile-page-content {
+  padding: 57px 13% 0 13% !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+}
+
+#logo-img {
+  display: none;
+}
+
+#dot-list {
+  display: inline-block;
+  margin: 0 auto;
+}
+
+.dot {
+  display: inline-block;
+  max-width: 119px !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+}
+
+/* TODO(pedrosimonetti): Hack to make the alignment of the bottom section
+ tab titles less ugly. The problem is that the items have a fixed position

[Evan Stade, 2012/08/07 21:57:12]

start each line with *

[pedrosimonetti2, 2012/08/08 08:14:22]

Rule + comment removed.

On 2012/08/07 21:57:12, Evan Stade wrote:

+ so "Apps" will have lots of padding compared to "Recently visited". Need
+ to find a better way to solve this problem. */

[Evan Stade, 2012/08/07 21:57:12]

a 60 line hack? I would rather you fix it than commit such a complicated hack.

[pedrosimonetti2, 2012/08/08 08:14:22]

Ack. We're going to delete the rest of the code in future CLs.

On 2012/08/07 21:57:12, Evan Stade wrote:

+.dot[title=Apps] input {
+  text-align: left;
+}
+
+.dot .selection-bar {
+  border: none !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+}
+
+.dot input {
+  color: #666 !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+  font-family: Arial;
+  font-size: 14px;
+  font-weight: normal;
+  text-align: center;
+}
+
+.dot.selected input {
+  color: rgb(221, 75, 57) !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+}
+
+.tile-page-scrollbar {
+  display: none;
+}
+
+#footer .menu-container,
+#footer #chrome-web-store-link,
+#trash {
+  display: none;
+}
+
+#page-list {
+  margin-top: 0;
+}
+
+.most-visited .color-stripe {
+  display: none;
+}
+
+.thumbnail-image,
+.thumbnail-wrapper {
+  border-radius: 2px !important;

[Evan Stade, 2012/08/07 21:57:12]

do not use !important

(here or elsewhere)

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+  opacity: 1 !important;
+}
+
+.tile-page-content {
+  padding: 0 !important;
+}
+
+.top-margin {
+  display: none;
+}
+
+#notification-container {
+  bottom: inherit !important;
+}
+
+/* =========================================================================
+   END OF Work around
+   ========================================================================= */
+
+
+
+

[Evan Stade, 2012/08/07 21:57:12]

random extra newlines

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+
+
+
+/* -----------------------------------------------------------------------------
+   General Styles
+----------------------------------------------------------------------------- */
+
+body {
+  background: whiteSmoke;
+  margin: 0;
+  overflow: hidden;
+  padding: 0;
+}
+
+

[Evan Stade, 2012/08/07 21:57:12]

2 more newlines than you need

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+
+/* -----------------------------------------------------------------------------
+   TODO(pedrosimonetti): refactor
+----------------------------------------------------------------------------- */
+
+#page-list {
+  display: -webkit-box;
+  position: static;
+}
+
+#card-slider-frame {
+  overflow: hidden;
+}
+
+#page-list-menu {
+  margin: 8px auto 30px;
+  text-align: center;
+}
+
+#dot-list {
+  color: #666;
+  font-family: Arial;

[Evan Stade, 2012/08/07 21:57:12]

wrong font again

[pedrosimonetti2, 2012/08/08 08:14:22]

I removed all font-family properties, but I included one in body with a TODO to
confirm the value with the UX folks, AFAIK they want to use Arial in all
platforms.

On 2012/08/07 21:57:12, Evan Stade wrote:

+  font-size: 13px;

[Evan Stade, 2012/08/07 21:57:12]

incorrectly specified font size again

[pedrosimonetti2, 2012/08/08 08:14:22]

All font-sizes converted to em.

On 2012/08/07 21:57:12, Evan Stade wrote:

+  height: 35px;
+  list-style: none;
+  margin: 0;
+  overflow: hidden;
+  padding: 0;
+  text-shadow: 0 1px 0 rgba(255, 255, 255, .7);
+}
+
+/* TODO: selected class */

[Evan Stade, 2012/08/07 21:57:12]

TODOs must have authors.

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+#dot-list li:first-child {
+  color: rgb(221, 75, 57);
+}
+
+#dot-list li {
+  display: inline-block;
+  margin-left: 13px;

[Evan Stade, 2012/08/07 21:57:12]

the margins should probably be ems as well.

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+  margin-right: 13px;
+  min-width: 55px; /* TODO: Confirm value with Marcin */

[Evan Stade, 2012/08/07 21:57:12]

2 spaces before comments.

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+  white-space: nowrap;
+}
+
+
+

[Evan Stade, 2012/08/07 21:57:12]

2 more newlines than you need

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+/* -----------------------------------------------------------------------------
+   TODO(pedrosimonetti): refactor

[Evan Stade, 2012/08/07 21:57:12]

comments should be clear to people who didn't write them.

[pedrosimonetti2, 2012/08/08 08:14:22]

Ack.

On 2012/08/07 21:57:12, Evan Stade wrote:

+----------------------------------------------------------------------------- */
+
+#card-slider-frame {
+  bottom: 0;
+  position: absolute;
+  text-align: center;
+  width: 100%;
+}
+
+.tile-page {
+  overflow: hidden;
+  position: relative;
+}
+
+.tile-page-content {
+  margin: 0 auto;
+  width: 748px; /* TODO move */

[Evan Stade, 2012/08/07 21:57:12]

comments should be clear to people who didn't write them.

[pedrosimonetti2, 2012/08/08 08:14:22]

Ack.

+}
+
+.tile-grid {
+  display: block;
+  margin: 0 auto;
+  overflow: hidden;
+}
+
+/* -----------------------------------------------------------------------------
+   New tile grid
+----------------------------------------------------------------------------- */
+
+.tile-row {
+  text-align: left;
+  white-space: nowrap;
+}
+
+.tile-cell {
+  display: inline-block;
+  position: relative;
+}
+
+.tile-cell:first-child {
+  margin-left: 0 !important;
+}
+
+

[Evan Stade, 2012/08/07 21:57:12]

extra newline

[pedrosimonetti2, 2012/08/08 08:14:22]

Done.

+/* -----------------------------------------------------------------------------
+   Size / Animation
+----------------------------------------------------------------------------- */
+
+#page-list {
+  -webkit-transition: all 201ms ease-in-out !important;
+  padding-bottom: 10px;
+}
+
+#card-slider-frame .tile-page-content {
+  width: 748px; /* TODO move */
+}
+
+#card-slider-frame .tile-grid {
+  -webkit-transform: translate3d(0,0,0);
+  -webkit-transition: all 201ms ease-in-out;
+  width: 732px;  /* TODO move */
+}
+
+#card-slider-frame .tile-grid-content {
+  -webkit-transform: translate3d(0,0,0);
+  -webkit-transition: all 201ms ease-in-out;

[Evan Stade, 2012/08/07 21:57:12]

why 201 ms?

[pedrosimonetti2, 2012/08/08 08:14:22]

The default value is 200ms, but I think we're going to change it to 300 or 400,
so I used 201 to make it easier to search/replace to the new value.

[Evan Stade, 2012/08/08 23:19:18]

animations in chrome are limited to 250ms.

+}
+
+#card-slider-frame .tile-row {
+  -webkit-transform: translate3d(0,0,0);
+  -webkit-transition: all 201ms ease-in-out; /* change to opacity only? */
+}
+
+/* -----------------------------------------------------------------------------
+   Size / Animation
+----------------------------------------------------------------------------- */
+
+.tile-cell {
+  -webkit-transform: translate3d(0,0,0);
+  height: 80px;
+  margin-bottom: 22px;
+  margin-left: 18px;
+  width: 132px;
+}
+
+/* TODO(pedrosimonetti): we need to resize the filler child too if we want
+   its animation to be the same as a normal tile */
+.tile-cell.filler  {
+  background: -webkit-linear-gradient(rgb(242, 242, 242), rgb(232, 232, 232));
+  border-color: rgb(224, 224, 224);
+  border-radius: 3px;
+  box-shadow: inset 0 2px 3px rgba(0, 0, 0, .09);
+  display: inline-block;
+  position: relative;
+  width: 132px;
+}
+
+.tile-cell .tile {
+  background: #fff;

[Evan Stade, 2012/08/08 23:19:18]

white

+  border: 1px solid rgb(192, 192, 192);
+  border-radius: 2px;
+  box-shadow: 0 1px 0 rgba(255, 255, 255, .7);
+  font: 16px Arial;
+  height: 78px;
+  text-align: center;
+  width: 130px;
+}
+
+.tile:hover {
+  border-color: rgb(127, 127, 127); /* TODO: confirm value with Marcin */
+}
+
+.xxxxtile-cell > div > span {

[Evan Stade, 2012/08/08 23:19:18]

are these x's supposed to be here?

+  display: inline-block;
+  position: absolute;
+  top: 27px;
+}
+
+/* -----------------------------------------------------------------------------
+   Tile Animation
+----------------------------------------------------------------------------- */
+
+.animate-tile .tile-cell {
+  -webkit-transition: all 201ms ease-in-out, opacity 101ms ease-out;
+}
+
+/* Animates entire columns of Tiles at once */
+.hide-col-0 .tile-col-0,
+.hide-col-1 .tile-col-1,
+.hide-col-2 .tile-col-2,
+.hide-col-3 .tile-col-3,
+.hide-col-4 .tile-col-4,
+.hide-col-5 .tile-col-5,
+.hide-col-6 .tile-col-6,
+.hide-col-7 .tile-col-7,
+.hide-col-8 .tile-col-8,
+.hide-col-9 .tile-col-9 {
+  margin-right: -10px;
+  opacity: 0 !important;
+  width: 10px !important;
+}
+
+.hide-row {
+  opacity: 0 !important;
+}
+.hide-row .tile-cell {
+  opacity: 1 !important;
+}
+
+

[Evan Stade, 2012/08/08 23:19:18]

you still have inconsistent # of newlines before new sections

+/* -----------------------------------------------------------------------------
+   Debug
+----------------------------------------------------------------------------- */
+
+.debug #card-slider-frame {
+  bottom: 0;
+  height: 95%;
+  position: absolute;
+  text-align: center;
+  width: 100%;
+}
+
+
+.debug .tile-grid {
+  height: 100% !important;
+}
+
+.debug .animate-tile .tile-cell {
+  -webkit-transition: all 201ms ease-in-out;
+}
+
+.debug #page-list-menu {
+  background: rgb(255, 170, 255);
+}
+
+.debug .tile-page-content {
+  background: rgb(119, 255, 255);
+}
+
+.debug .tile-row {
+  background: rgb(255, 255, 119);
+}
+
+.debug .hide-row {
+  opacity: 0.35 !important;
+}
+
+.debug .hide-row .tile-cell > div {
+  background-color: lightgray !important;
+  border: 1px solid gray;
+  color: gray;
+}
+
+.debug .hide-col-0 .tile-col-0,
+.debug .hide-col-1 .tile-col-1,
+.debug .hide-col-2 .tile-col-2,
+.debug .hide-col-3 .tile-col-3,
+.debug .hide-col-4 .tile-col-4 {
+  background-color: lightgray;
+}