Issue 10829109: Don't show performance warnings when compiling dependents when compiling with msvc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Issue 10829109: Don't show performance warnings when compiling dependents when compiling with msvc (Closed)

Created:
8 years, 4 months ago by piscisaureus

Modified:
5 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Visibility:
Public.

Description

v8.gyp disables specific msvc warnings (like: "forcing uint32_t to boolean"), but they still show up. This happens because they are only disabled for the 'v8_base' target, but since these warnings are generated at link time, they also show up when linking 'mksnapshot' or 'v8_nosnapshot'. This patch fixes that.

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/gyp/v8.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download