Http cache: Make sure that issuing a byte range request

net/http/partial_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/partial_data.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/format_macros.h"
 #include "base/logging.h"
@@ skipping 224 matching lines @@
 }
 
 bool PartialData::IsLastRange() const {
   return final_range_;
 }
 
 bool PartialData::UpdateFromStoredHeaders(const HttpResponseHeaders* headers,
                                           disk_cache::Entry* entry,
                                           bool truncated) {
   resource_size_ = 0;
-  if (!headers->HasStrongValidators())
-    return false;
-
   if (truncated) {
     DCHECK_EQ(headers->response_code(), 200);
     // We don't have the real length and the user may be trying to create a
     // sparse entry so let's not write to this entry.
     if (byte_range_.IsValid())
       return false;
 
+    if (!headers->HasStrongValidators())
+      return false;
+
     // Now we avoid resume if there is no content length, but that was not
     // always the case so double check here.
     int64 total_length = headers->GetContentLength();
     if (total_length <= 0)
       return false;
 
     truncated_ = true;
     initial_validation_ = true;
     sparse_entry_ = false;
     int current_len = entry->GetDataSize(kDataStream);
     byte_range_.set_first_byte_position(current_len);
     resource_size_ = total_length;
     current_range_start_ = current_len;
     cached_min_len_ = current_len;
     cached_start_ = current_len + 1;
     return true;
   }
 
-  if (headers->response_code() == 200) {
+  if (headers->response_code() != 206) {
     DCHECK(byte_range_.IsValid());
     sparse_entry_ = false;
     resource_size_ = entry->GetDataSize(kDataStream);
     DVLOG(2) << "UpdateFromStoredHeaders size: " << resource_size_;

[gavinp, 2012/07/30 18:35:07]

Should this DVLOG be deleted??

[rvargas (doing something else), 2012/07/30 21:38:52]

Not sure. I've used this one to get an idea of where something is amiss. But
more often than not I use some other technique rather than longs.

     return true;
   }
 
   if (!headers->HasStrongValidators())
     return false;
 
   int64 length_value = headers->GetContentLength();
   if (length_value <= 0)
     return false;  // We must have stored the resource length.
 
@@ skipping 199 matching lines @@
   cached_min_len_ = result;
   if (result >= 0)
     result = 1;  // Return success, go ahead and validate the entry.
 
   CompletionCallback cb = callback_;
   callback_.Reset();
   cb.Run(result);
 }
 
 }  // namespace net