Upstream sqlite gyp changes for Android.

third_party/sqlite/sqlite.gyp

Index: third_party/sqlite/sqlite.gyp
diff --git a/third_party/sqlite/sqlite.gyp b/third_party/sqlite/sqlite.gyp
index 63aea03e525fe93bd702283ba9f630c7183e3ddd..cf9ce3bb9a8e73d4db17f3ee07a459395765a1ca 100644
--- a/third_party/sqlite/sqlite.gyp
+++ b/third_party/sqlite/sqlite.gyp
@@ -34,11 +34,6 @@
                 ],
           },
         ],
-        ['OS == "android"', {
-          'defines': [
-            'SQLITE_TEMP_STORE=3',
-          ],
-        }],
         ['use_system_sqlite', {
           'type': 'none',
           'direct_dependent_settings': {
@@ -55,7 +50,7 @@
                 ],
               },
             }],
-            ['os_posix == 1 and OS != "mac" and OS != "ios"', {
+            ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', {
               'direct_dependent_settings': {
                 'cflags': [
                   # This next command produces no output but it it will fail
@@ -128,7 +123,17 @@
                 ],
               },
             }],
-            ['os_posix == 1 and OS != "mac"', {
+            ['OS == "android"', {
+              'defines': [
+                'HAVE_USLEEP=1',
+                'SQLITE_DEFAULT_JOURNAL_SIZE_LIMIT=1048576',
+                'SQLITE_DEFAULT_AUTOVACUUM=1',
+                'SQLITE_TEMP_STORE=3',
+                'SQLITE_ENABLE_FTS3_BACKWARDS',
+                'DSQLITE_DEFAULT_FILE_FORMAT=4',

[andreip3000, 2012/08/01 11:46:06]

Should we match the flags that Android uses?

https://android.googlesource.com/platform/external/sqlite/+/2d758ba484351cd86...

I remember that was our intention originally but I think we diverged over time.

One notable setting is powersave overwrite which was enabled in this change:

https://android.googlesource.com/platform/external/sqlite/+/2d758ba484351cd86...

Looking at the SQLite documentation, it seems the default is 'on' anyway.
However, maybe it's better to be explicit about it too (like Android is).

[Yaron, 2012/08/04 01:14:43]

I took the set that we had previously and just removed redundant ones (from the
shared block on L12 above) 

+              ],
+            }],
+            ['os_posix == 1 and OS != "mac" and OS != "android"', {
               'cflags': [
                 # SQLite doesn't believe in compiler warnings,
                 # preferring testing.
@@ -157,7 +162,7 @@
     },
   ],
   'conditions': [
-    ['os_posix == 1 and OS != "mac" and OS != "ios" and not use_system_sqlite', {
+    ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android" and not use_system_sqlite', {
       'targets': [
         {
           'target_name': 'sqlite_shell',