Add FileResource/FileList parser.

chrome/browser/chromeos/gdata/drive_api_parser_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/path_service.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/gdata/drive_api_parser.h"
+#include "chrome/browser/chromeos/gdata/gdata_util.h"
 #include "chrome/common/chrome_paths.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Value;
 using base::DictionaryValue;
 using base::ListValue;
 
 #define IF_EXPECT_EQ(arg1, arg2) \
   EXPECT_EQ(arg1, arg2); \
   if (arg1 == arg2)
@@ skipping 46 matching lines @@
   std::string error;
   scoped_ptr<Value> document(LoadJSONFile("applist.json"));
   ASSERT_TRUE(document.get());
 
   ASSERT_EQ(Value::TYPE_DICTIONARY, document->GetType());
   scoped_ptr<AppList> applist(new AppList);
   EXPECT_TRUE(applist->Parse(*document));
 
   EXPECT_EQ("\"Jm4BaSnCWNND-noZsHINRqj4ABC/tuqRBw0lvjUdPtc_2msA1tN4XYZ\"",
             applist->etag());
   IF_EXPECT_EQ(2U, applist->items().size()) {

[satorux1, 2012/07/30 16:34:33]

ASSERT_EQ

[kochi, 2012/07/31 08:07:58]

Done.

     // Check Drive app 1
     const AppResource& app1 = *applist->items()[0];
     EXPECT_EQ("123456788192", app1.id());
     EXPECT_EQ("Drive app 1", app1.name());
     EXPECT_EQ("", app1.object_type());
     EXPECT_EQ(true, app1.supports_create());
     EXPECT_EQ(true, app1.supports_import());
     EXPECT_EQ(true, app1.is_installed());
     EXPECT_EQ(false, app1.is_authorized());
     EXPECT_EQ("https://chrome.google.com/webstore/detail/"
               "abcdefghabcdefghabcdefghabcdefgh",
               app1.product_url().spec());
 
     IF_EXPECT_EQ(1U, app1.primary_mimetypes().size()) {

[satorux1, 2012/07/30 16:34:33]

ASSERT_EQ

[kochi, 2012/07/31 08:07:58]

Done.

       EXPECT_EQ("application/vnd.google-apps.drive-sdk.123456788192",
                 *app1.primary_mimetypes()[0]);
     }
 
     IF_EXPECT_EQ(2U, app1.secondary_mimetypes().size()) {
       EXPECT_EQ("text/html", *app1.secondary_mimetypes()[0]);
       EXPECT_EQ("text/plain", *app1.secondary_mimetypes()[1]);
     }
 
     IF_EXPECT_EQ(2U, app1.primary_file_extensions().size()) {
@@ skipping 43 matching lines @@
 
     IF_EXPECT_EQ(3U, app2.icons().size()) {
       const DriveAppIcon& icon2 = *app2.icons()[1];
       EXPECT_EQ(DriveAppIcon::DOCUMENT, icon2.category());
       EXPECT_EQ(10, icon2.icon_side_length());
       EXPECT_EQ("http://www.example.com/d10.png", icon2.icon_url().spec());
     }
   }
 }
 
+// Test file list parsing.
+TEST_F(DriveAPIParserTest, FileListParser) {
+  std::string error;
+  scoped_ptr<Value> document(LoadJSONFile("filelist.json"));
+  ASSERT_TRUE(document.get());
+
+  ASSERT_EQ(Value::TYPE_DICTIONARY, document->GetType());
+  scoped_ptr<FileList> filelist(new FileList);
+  EXPECT_TRUE(filelist->Parse(*document));
+
+  EXPECT_EQ("\"WtRjAPZWbDA7_fkFjc5ojsEvDEF/zyHTfoHpnRHovyi8bWpwK0DXABC\"",
+            filelist->etag());
+  EXPECT_EQ("EAIaggELEgA6egpi96It9mH_____f_8AAP__AAD_okhU-cHLz83KzszMxsjMzs_Ry"
+            "NGJnridyrbHs7u9tv8AAP__AP7__n__AP8AokhU-cHLz83KzszMxsjMzs_RyNGJnr"
+            "idyrbHs7u9tv8A__4QZCEiXPTi_wtIgTkAAAAAngnSXUgCDEAAIgsJPgart10AAAA"
+            "ABC", filelist->next_page_token());
+  EXPECT_EQ(GURL("https://www.googleapis.com/drive/v2/files?pageToken=EAIaggEL"
+                 "EgA6egpi96It9mH_____f_8AAP__AAD_okhU-cHLz83KzszMxsjMzs_RyNGJ"
+                 "nridyrbHs7u9tv8AAP__AP7__n__AP8AokhU-cHLz83KzszMxsjMzs_RyNGJ"
+                 "nridyrbHs7u9tv8A__4QZCEiXPTi_wtIgTkAAAAAngnSXUgCDEAAIgsJPgar"
+                 "t10AAAAABC"), filelist->next_link());
+
+  IF_EXPECT_EQ(3U, filelist->items().size()) {

[satorux1, 2012/07/30 16:34:33]

ASSERT_EQ(3U, filelist->items().size());

IF_EXPECT_EQ seems to be a bad idea. Can you get rid of it?

[kochi, 2012/07/31 08:07:58]

Done.

I copied the macro from gdata_wapi_parser_unittest.cc,
and I thought the idea is that if the first check fails,
the following enclosed tests also fail, and log would
get messy.

Anyway, failing test fails at ASSERT, so this looks
better to me.

[satorux1, 2012/08/01 04:35:45]

Could you also remove these IF_ macros from  gdata_wapi_parser_unittest.cc?

+    // Check file 1 (a file)
+    const FileResource& file1 = *filelist->items()[0];
+    EXPECT_EQ("0B4v7G8yEYAWHUmRrU2lMS2hLABC", file1.id());
+    EXPECT_EQ("\"WtRjAPZWbDA7_fkFjc5ojsEvDEF/MTM0MzM2NzgwMDIXYZ\"",
+              file1.etag());
+    EXPECT_EQ("My first file data", file1.title());
+    EXPECT_EQ("application/octet-stream", file1.mime_type());
+
+    base::Time modified_time;
+    ASSERT_TRUE(gdata::util::GetTimeFromString("2012-07-27T05:43:20.269Z",
+                                               &modified_time));
+    EXPECT_EQ(modified_time, file1.modified_by_me_date());
+    EXPECT_EQ(GURL("https://www.example.com/download"), file1.download_url());
+    EXPECT_EQ("ext", file1.file_extension());
+    EXPECT_EQ("d41d8cd98f00b204e9800998ecf8427e", file1.md5_checksum());
+    EXPECT_EQ(1000U, file1.file_size());
+
+    // Check file 2 (a Google Document)
+    const FileResource& file2 = *filelist->items()[1];
+    EXPECT_EQ("Test Google Document", file2.title());
+    EXPECT_EQ("application/vnd.google-apps.document", file2.mime_type());
+    EXPECT_EQ(0U, file2.file_size());
+
+    // Check file 3 (a folder)
+    const FileResource& file3 = *filelist->items()[2];
+    EXPECT_EQ(0U, file3.file_size());
+    EXPECT_EQ("TestFolder", file3.title());
+    EXPECT_EQ("application/vnd.google-apps.folder", file3.mime_type());
+    ASSERT_TRUE(file3.IsFolder());
+  }
+}
+
 }  // namespace gdata