Fix third-party license information for a number of projects

Fix third-party license information for a number of projects

Also fix a couple of bugs in the license tool.
- When scanning, ignore directories that don't contain any files, on the
  assumption that these are DEPS directories for projects not used by our
  current configuration.
- Don't recurse into directories in ADDITIONAL_PATHS, just as we don't for
  regular third_party/foo directories.

Notes
- License file for third_party/mozc was taken from source header.
- LICENSE.chromium_os was copied from Chromium OS source tree.

This fixes 'licenses.py scan' for an Android checkout.

BUG=138921
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148693

[Steve Block, 2012-07-26 19:06:37]

This depends logically on http://codereview.chromium.org/10827044 and
http://codereview.chromium.org/10827038

[Nico, 2012-07-26 19:45:04]

Looks fine except for that one url.

http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os
File LICENSE.chromium_os (right):

http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os#newcode1
LICENSE.chromium_os:1: // Copyright (c) 2006-2009 The Chromium OS Authors. All
rights reserved.
I haven't seen a LICENSE.chromium_os file before. Is this filename convention
documented anywhere?

http://codereview.chromium.org/10829042/diff/9/third_party/mozc/LICENSE
File third_party/mozc/LICENSE (right):

http://codereview.chromium.org/10829042/diff/9/third_party/mozc/LICENSE#newcode1
third_party/mozc/LICENSE:1: Copyright 2010-2011, Google Inc.
2012?

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py
File tools/licenses.py (right):

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py#newcode126
tools/licenses.py:126: "License File": "/webkit/LICENSE",
nit: It looks like someone tried to keep these ordered alphabetically by path
(case-insensitively). These two entries should be further down, I think.

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py#newcode134
tools/licenses.py:134: "URL": "http://code.google.com/apis/protocolbuffers",
This looks wrong.

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py#newcode277
tools/licenses.py:277: """Determines whether a directory contains any files."""
"any files in any subdirectory"

[Steve Block, 2012-07-26 22:11:00]

Thanks Nico

http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os
File LICENSE.chromium_os (right):

http://codereview.chromium.org/10829042/diff/9/LICENSE.chromium_os#newcode1
LICENSE.chromium_os:1: // Copyright (c) 2006-2009 The Chromium OS Authors. All
rights reserved.
No, there's no precedent that I'm aware of, but this seemed like a sensible
name. The alternative is to move the DEPS content of third_party/cros_system_api
into a subdirectory and create third_party/cros_system_api/LICENSE, but this
would be a more involved change. Also, I suspect that there's other code in the
tree that should be linking to the generic Chromium OS license, so it makes
sense to put it in a shared location.

http://codereview.chromium.org/10829042/diff/9/third_party/mozc/LICENSE
File third_party/mozc/LICENSE (right):

http://codereview.chromium.org/10829042/diff/9/third_party/mozc/LICENSE#newcode1
third_party/mozc/LICENSE:1: Copyright 2010-2011, Google Inc.
All of the license headers in the source use this date range.

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py
File tools/licenses.py (right):

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py#newcode126
tools/licenses.py:126: "License File": "/webkit/LICENSE",
Hmm, they were still out of order, even if considered case-insensitive, but that
might create less churn - done.

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py#newcode134
tools/licenses.py:134: "URL": "http://code.google.com/apis/protocolbuffers",
This is from the README, but I guess it's specific to proto-buffers, so I've
replaced it with a generic Chromium OS URL.

http://codereview.chromium.org/10829042/diff/9/tools/licenses.py#newcode277
tools/licenses.py:277: """Determines whether a directory contains any files."""
On 2012/07/26 19:45:04, Nico wrote:
> "any files in any subdirectory"

Done.

[Nico, 2012-07-26 22:16:30]

lgtm

Thanks for working on this!

[commit-bot: I haz the power, 2012-07-26 22:45:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/steveblock@chromium.org/10829042/5002

[commit-bot: I haz the power, 2012-07-27 01:52:12]

Change committed as 148693