Use current gtk dialogs in linux_aura.

Use current gtk dialogs in linux_aura.

They payoff for the last month of refactoring: We now use the LinuxUI interface
to generate gtk file selection dialogs from the shim library. We could
theoretically make a Qt or EFL shim and get those desktops' native open
dialogs.

BUG=136909, 134167
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148813

[Elliot Glaysher, 2012-07-26 18:14:07]

derat: x11 binding code
sky: owner the stamp

[Elliot Glaysher, 2012-07-27 16:59:57]

thestig: Can you review the gtk parts instead of derat?
ben: Can you stamp instead of sky?

[Daniel Erat, 2012-07-27 17:11:41]

I'm in today and taking a look now.

[Ben Goodger (Google), 2012-07-27 17:20:20]

lgtm for the generic bits if derat is happy.

[Daniel Erat, 2012-07-27 17:21:56]

lgtm

http://codereview.chromium.org/10829021/diff/2001/chrome/browser/ui/libgtk2ui...
File chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc (right):

http://codereview.chromium.org/10829021/diff/2001/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc:33: const char*
kAuraTransientParent = "aura-transient-parent";
nit: const char kAuraTransientParent[]

http://codereview.chromium.org/10829021/diff/2001/chrome/browser/ui/libgtk2ui...
chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc:57: // TODO(erg):
This needs to be a window listener that listens to the parent
nit: should this TODO be moved to OnWindowDestroying()?

http://codereview.chromium.org/10829021/diff/2001/ui/base/dialogs/select_file...
File ui/base/dialogs/select_file_dialog.cc (right):

http://codereview.chromium.org/10829021/diff/2001/ui/base/dialogs/select_file...
ui/base/dialogs/select_file_dialog.cc:71: // TODO(erg): Proxy to LinuxUI here.
nit: remove TODO?

http://codereview.chromium.org/10829021/diff/2001/ui/base/linux_ui.h
File ui/base/linux_ui.h (right):

http://codereview.chromium.org/10829021/diff/2001/ui/base/linux_ui.h#newcode9
ui/base/linux_ui.h:9: #include "ui/base/dialogs/select_file_policy.h"
nit: just forward-declare SelectFilePolicy in the header?

[commit-bot: I haz the power, 2012-07-27 17:38:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10829021/10002

[commit-bot: I haz the power, 2012-07-27 18:21:14]

Try job failure for 10829021-10002 on linux_chromeos for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-07-27 18:25:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10829021/10002

[commit-bot: I haz the power, 2012-07-27 21:23:11]

Change committed as 148813