Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Unified Diff: ash/wm/keyboard_overlay_view.h

Issue 10829003: Move the keyboard overlay view to ash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/keyboard_overlay_view.h
diff --git a/chrome/browser/ui/views/keyboard_overlay_dialog_view.h b/ash/wm/keyboard_overlay_view.h
similarity index 50%
rename from chrome/browser/ui/views/keyboard_overlay_dialog_view.h
rename to ash/wm/keyboard_overlay_view.h
index 2eecf3ef292a20360b0a8ed79ae7ae1ab03c701b..58c3a93f7be900edf25e5af17f3be293c90f8f35 100644
--- a/chrome/browser/ui/views/keyboard_overlay_dialog_view.h
+++ b/ash/wm/keyboard_overlay_view.h
@@ -2,12 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DIALOG_VIEW_H_
-#define CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DIALOG_VIEW_H_
+#ifndef ASH_WM_KEYBOARD_OVERLAY_VIEW_H_
Ben Goodger (Google) 2012/07/25 16:36:51 hrm... I think this should be in its own dir.. e.
mazda 2012/07/25 17:36:32 Done.
+#define ASH_WM_KEYBOARD_OVERLAY_VIEW_H_
+#include "ash/ash_export.h"
#include "base/compiler_specific.h"
#include "ui/views/controls/webview/web_dialog_view.h"
+class GURL;
+
namespace content {
class BrowserContext;
}
@@ -17,22 +20,23 @@ class WebDialogDelegate;
}
// A customized dialog view for the keyboard overlay.
-class KeyboardOverlayDialogView : public views::WebDialogView {
+class ASH_EXPORT KeyboardOverlayView : public views::WebDialogView {
public:
- KeyboardOverlayDialogView(content::BrowserContext* context,
- ui::WebDialogDelegate* delegate,
- WebContentsHandler* handler);
- virtual ~KeyboardOverlayDialogView();
+ KeyboardOverlayView(content::BrowserContext* context,
+ ui::WebDialogDelegate* delegate,
+ WebContentsHandler* handler);
+ virtual ~KeyboardOverlayView();
// Shows the keyboard overlay.
static void ShowDialog(content::BrowserContext* context,
- WebContentsHandler* handler);
+ WebContentsHandler* handler,
+ const GURL& url);
private:
// Overridden from views::WidgetDelegate:
virtual void WindowClosing() OVERRIDE;
- DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayDialogView);
+ DISALLOW_COPY_AND_ASSIGN(KeyboardOverlayView);
};
-#endif // CHROME_BROWSER_UI_VIEWS_KEYBOARD_OVERLAY_DIALOG_VIEW_H_
+#endif // ASH_WM_KEYBOARD_OVERLAY_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698