Move the keyboard overlay view to ash.

Move the keyboard overlay view to ash.

This change introduces an issue when Shift+Alt  is pressed (http://code.google.com/p/chromium/issues/detail?id=131159).
I'll fix it shortly together with the more general issue (http://code.google.com/p/chromium/issues/detail?id=129834).

BUG=124222
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148383

[mazda, 2012-07-25 16:16:37]

Hi Ben,

Could you review this change?

[Ben Goodger (Google), 2012-07-25 16:36:51]

two important comments below, otherwise LGTM

http://codereview.chromium.org/10829003/diff/7002/ash/wm/keyboard_overlay_view.h
File ash/wm/keyboard_overlay_view.h (right):

http://codereview.chromium.org/10829003/diff/7002/ash/wm/keyboard_overlay_vie...
ash/wm/keyboard_overlay_view.h:5: #ifndef ASH_WM_KEYBOARD_OVERLAY_VIEW_H_
hrm... I think this should be in its own dir..

e.g. ash/keyboard_overlay

http://codereview.chromium.org/10829003/diff/7002/chrome/browser/ui/views/ash...
File chrome/browser/ui/views/ash/chrome_shell_delegate.cc (right):

http://codereview.chromium.org/10829003/diff/7002/chrome/browser/ui/views/ash...
chrome/browser/ui/views/ash/chrome_shell_delegate.cc:266: std::string
url(chrome::kChromeUIKeyboardOverlayURL);
as a next step, you should think about how to remove this function entirely
(i.e. all the show logic should exist within ash too)

[mazda, 2012-07-25 17:36:32]

Thank you for your comments.
I created ash/keyboard_overlay and moved files there.

http://codereview.chromium.org/10829003/diff/7002/ash/wm/keyboard_overlay_view.h
File ash/wm/keyboard_overlay_view.h (right):

http://codereview.chromium.org/10829003/diff/7002/ash/wm/keyboard_overlay_vie...
ash/wm/keyboard_overlay_view.h:5: #ifndef ASH_WM_KEYBOARD_OVERLAY_VIEW_H_
On 2012/07/25 16:36:51, Ben Goodger (Google) wrote:
> hrm... I think this should be in its own dir..
> 
> e.g. ash/keyboard_overlay

Done.

http://codereview.chromium.org/10829003/diff/7002/chrome/browser/ui/views/ash...
File chrome/browser/ui/views/ash/chrome_shell_delegate.cc (right):

http://codereview.chromium.org/10829003/diff/7002/chrome/browser/ui/views/ash...
chrome/browser/ui/views/ash/chrome_shell_delegate.cc:266: std::string
url(chrome::kChromeUIKeyboardOverlayURL);
On 2012/07/25 16:36:51, Ben Goodger (Google) wrote:
> as a next step, you should think about how to remove this function entirely
> (i.e. all the show logic should exist within ash too)

Sure. I'll continue to work on it.
I added a TODO comment.

[commit-bot: I haz the power, 2012-07-25 17:58:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mazda@chromium.org/10829003/9003

[commit-bot: I haz the power, 2012-07-25 19:33:53]

Change committed as 148383