Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc

Issue 10828401: Add a getter for search provider logos. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and switch to a simple getter. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
index f0e33c0c15b153c6d053000d4000beccd2aa5798..c53230704d8e4d61cd6e3bd0ebc61a8b169d81fe 100644
--- a/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
+++ b/chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc
@@ -176,3 +176,23 @@ TEST_F(TemplateURLPrepopulateDataTest, GetEngineTypeAdvanced) {
EXPECT_EQ(SEARCH_ENGINE_OTHER,
TemplateURLPrepopulateData::GetEngineType("invalid:search:url"));
}
+
+TEST(TemplateURLPrepopulateDataTest, GetLogoURLGoogle) {
+ EXPECT_EQ("www.google.com",
msw 2012/08/27 21:57:26 nit: get each logo URL once and test the host/sche
samarth 2012/08/28 16:18:15 Done.
+ TemplateURLPrepopulateData::GetLogoURL(
+ "http://www.google.com/").host());
+ EXPECT_EQ("www.google.com",
+ TemplateURLPrepopulateData::GetLogo200PercentURL(
+ "http://www.google.com/").host());
+ EXPECT_TRUE(TemplateURLPrepopulateData::GetLogoURL(
+ "http://www.google.com/").SchemeIsSecure());
+ EXPECT_TRUE(TemplateURLPrepopulateData::GetLogo200PercentURL(
+ "http://www.google.com/").SchemeIsSecure());
+}
+
+TEST(TemplateURLPrepopulateDataTest, GetLogoURLUnknown) {
+ EXPECT_TRUE(TemplateURLPrepopulateData::GetLogoURL(
+ "http://www.yahoo.com/").is_empty());
msw 2012/08/27 21:57:26 nit: this will fail if/when yahoo is added, use a
samarth 2012/08/28 16:18:15 Done.
+ EXPECT_TRUE(TemplateURLPrepopulateData::GetLogoURL(
+ "invalid:search:url").is_empty());
+}

Powered by Google App Engine
This is Rietveld 408576698