Always call WasShown() before trying to paint.

chrome/browser/ui/browser_instant_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_instant_controller.h"
 
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/instant/instant_unload_handler.h"
@@ skipping 60 matching lines @@
   // support for the new disposition.
   NOTREACHED();
   return false;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserInstantController, InstantControllerDelegate implementation:
 
 void BrowserInstantController::ShowInstant() {
   TabContents* preview = instant_->GetPreviewContents();
+  preview->web_contents()->WasShown();

[sky, 2012/08/20 16:29:31]

Any reason you're not putting this in InstantController?

[sreeram_google.com, 2012/08/20 16:36:45]

No particular reason. Historically, this code has been here, in Browser land. It
seems reasonable that the Browser should operate on the active tab.
InstantController only uses the active tab for things like pointer comparison,
extracting profile and passing on to other methods. It doesn't directly
"operate" on it. Let me know if you'd like to change that.

[sreeram, 2012/08/20 16:46:25]

I forgot to add that, since the Browser operates on the active tab, it seems
reasonable to have it operate on the preview as well (since the Hide() on one
and Show() on the other go hand in hand).

   browser_->window()->ShowInstant(preview);
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_INSTANT_CONTROLLER_SHOWN,
       content::Source<InstantController>(instant()),
       content::NotificationService::NoDetails());
 
   // TODO(beng): Investigate if we can avoid this and instead rely on the
   //             visibility of the WebContentsView.
   chrome::GetActiveWebContents(browser_)->WasHidden();
-  preview->web_contents()->WasShown();
 }
 
 void BrowserInstantController::HideInstant() {
+  if (chrome::GetActiveWebContents(browser_))
+    chrome::GetActiveWebContents(browser_)->WasShown();

[sky, 2012/08/20 16:29:31]

How come you're moving this?

[sreeram_google.com, 2012/08/20 16:36:45]

Same reason as before. When we call browser_->window()->HideInstant(), it may
try to paint the active tab and ask for its backing store, which might trigger
the DCHECK() since it's hidden. Hence, make the active tab visible first.

+
   browser_->window()->HideInstant();
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_INSTANT_CONTROLLER_HIDDEN,
       content::Source<InstantController>(instant()),
       content::NotificationService::NoDetails());
 
-  if (chrome::GetActiveWebContents(browser_))
-    chrome::GetActiveWebContents(browser_)->WasShown();
   if (TabContents* preview = instant_->GetPreviewContents())
     preview->web_contents()->WasHidden();
 }
 
 void BrowserInstantController::CommitInstant(TabContents* preview) {
   TabContents* active_tab = chrome::GetActiveTabContents(browser_);
   int index = browser_->tab_strip_model()->GetIndexOfTabContents(active_tab);
   DCHECK_NE(TabStripModel::kNoTab, index);
   // TabStripModel takes ownership of |preview|.
   browser_->tab_strip_model()->ReplaceTabContentsAt(index, preview);
@@ skipping 59 matching lines @@
       browser_->is_type_tabbed() && !browser_->profile()->IsOffTheRecord()) {
     instant_.reset(new InstantController(this, InstantController::INSTANT));
     instant_unload_handler_.reset(new InstantUnloadHandler(browser_));
   } else {
     instant_.reset();
     instant_unload_handler_.reset();
   }
 }
 
 }  // namespace chrome