Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/about_flags.cc

Issue 10828373: [net] Add AsyncDns field trial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: better var names Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | chrome/browser/io_thread.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 54438cdd50dd3383b86b8665f08f9d24703a02c9..aa4c0cda4dfeba4c8cc54660100c72d43c89277f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -148,6 +148,14 @@ const Experiment::Choice kPointerLockUIChoices[] = {
switches::kDisablePointerLock, ""}
};
+const Experiment::Choice kAsyncDnsChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
+ switches::kDisableAsyncDns, ""},
+ { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
+ switches::kEnableAsyncDns, ""}
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
@@ -521,7 +529,7 @@ const Experiment kExperiments[] = {
IDS_FLAGS_ENABLE_ASYNC_DNS_NAME,
IDS_FLAGS_ENABLE_ASYNC_DNS_DESCRIPTION,
kOsWin | kOsMac | kOsLinux | kOsCrOS,
cbentzel 2012/08/20 11:45:56 Should you remove kOsCros at this point? I thought
szym 2012/08/20 17:54:21 There are, but I'm currently working on the merger
cbentzel 2012/08/21 10:50:53 Yeah, disable for now especially since this change
- SINGLE_VALUE_TYPE(switches::kEnableAsyncDns)
+ MULTI_VALUE_TYPE(kAsyncDnsChoices)
},
{
"enable-video-track",
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | chrome/browser/io_thread.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698