Don't show the button for hidden page/browser actions or script badges.

chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm

Index: chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm
===================================================================
--- chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm	(revision 152078)
+++ chrome/browser/ui/cocoa/location_bar/page_action_decoration.mm	(working copy)
@@ -286,7 +286,9 @@
       if (extension_id != page_action_->extension_id())
         break;
       NSRect frame = owner_->GetPageActionFrame(page_action_);
-      ActivatePageAction(frame);
+      // |frame| can be empty if the page action is hidden.
+      if (!NSIsEmptyRect(frame))
+        ActivatePageAction(frame);

[Scott Hess - ex-Googler, 2012/08/17 17:13:17]

Could you just check IsVisible() directly rather than bouncing through the
owner_?

Also, is not executing the page action the right choice in this case?  Seems
like the notification shouldn't even have been sent if it's not visible.

[Finnur, 2012/08/20 11:41:45]

So, this is work in progress. Ideally, we'd want the shortcut to not be active
if the page action isn't visible. However, there is more work that is required
for that to take place. But for now I've added the IsVisible check to prevent
the bubble from showing up unanchored when the page action is not visible. 

       break;
     }