Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 10828364: Don't show the button for hidden page/browser actions or script badges. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
===================================================================
--- chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm (revision 152076)
+++ chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm (working copy)
@@ -213,7 +213,9 @@
if (!extension)
break;
BrowserActionButton* button = [owner_ buttonForExtension:extension];
- [owner_ browserActionClicked:button];
+ // |button| can be NULL when the browser action has its button hidden.
+ if (button)
+ [owner_ browserActionClicked:button];
break;
}
default:
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('j') | chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698