Don't show the button for hidden page/browser actions or script badges.

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "browser_actions_controller.h"
 
 #include <cmath>
 #include <string>
 
 #include "base/sys_string_conversions.h"
@@ skipping 195 matching lines @@
         if (window != browser_->window()->GetNativeWindow())
           break;
         ExtensionService* service = browser_->profile()->GetExtensionService();
         if (!service)
           break;
         const Extension* extension = service->GetExtensionById(extension_id,
                                                                false);
         if (!extension)
           break;
         BrowserActionButton* button = [owner_ buttonForExtension:extension];
-        [owner_ browserActionClicked:button];
+        // |button| can be NULL when the browser action has its button hidden.

[Scott Hess - ex-Googler, 2012/08/17 17:13:17]

s/NULL/nil/ for Objective-C objects.  Unless BrowserActionButton is some C++
object.

+        if (button)
+          [owner_ browserActionClicked:button];

[Scott Hess - ex-Googler, 2012/08/17 17:13:17]

This combination almost makes me wish you could write:
  [owner_ browserActionClickedForExtension:extension];

[Finnur, 2012/08/20 11:41:45]

Yeah, it is a bit silly because the function actually doesn't want a
BrowserActionButton* since it converts |button| straight away to a const
Extension* and uses that. Changed that.

[Finnur, 2012/08/20 14:03:34]

Actually, I take that back (and reverted this change).

Basically, changing it to browserActionClickedForExtension:extension causes a
crash in other tests and it wasn't obvious why. We get back a NULL
browser_action in ExtensionToolbarModel::ExecuteBrowserAction and it would (of
course) crash trying to verify that it was visible. Anyway, this change was
perhaps a bit orthogonal to the change at hand, so I'm taking this attempt out
of the CL. If it passes green on the try servers (after reverting back) then
I'll check in.

On 2012/08/20 11:41:45, Finnur wrote:

[Scott Hess - ex-Googler, 2012/08/20 22:59:34]

Makes sense (I think).

On 2012/08/20 14:03:34, Finnur wrote:

         break;
       }
       default:
         NOTREACHED() << L"Unexpected notification";
     }
   }
 
   // ExtensionToolbarModel::Observer implementation.
   void BrowserActionAdded(const Extension* extension, int index) {
     [owner_ createActionButtonForExtension:extension withIndex:index];
@@ skipping 633 matching lines @@
   const extensions::ExtensionList& toolbar_items =
       toolbarModel_->toolbar_items();
   if (index < toolbar_items.size()) {
     const Extension* extension = toolbar_items[index];
     return [buttons_ objectForKey:base::SysUTF8ToNSString(extension->id())];
   }
   return nil;
 }
 
 @end