Don't show the button for hidden page/browser actions or script badges.

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
@@ skipping 392 matching lines @@
   decoration->UpdateVisibility(contents, GURL(toolbar_model_->GetText()));
 }
 
 NSRect LocationBarViewMac::GetPageActionFrame(ExtensionAction* page_action) {
   PageActionDecoration* decoration = GetPageActionDecoration(page_action);
   if (!decoration)
     return NSZeroRect;
 
   AutocompleteTextFieldCell* cell = [field_ cell];
   NSRect frame = [cell frameForDecoration:decoration inFrame:[field_ bounds]];
-  DCHECK(!NSIsEmptyRect(frame));

[Finnur, 2012/08/17 12:18:16]

When I factored GetPageActionFrame out of GetPageActionBubblePoint, I moved this
DCHECK along with it. However, GetPageActionFrame can be called for PageActions
that are not visible, so I've moved the DCHECK back into
GetPageActionBubblePoint (and converted it to NOTREACHED).

   return frame;
 }
 
 NSPoint LocationBarViewMac::GetPageActionBubblePoint(
     ExtensionAction* page_action) {
   PageActionDecoration* decoration = GetPageActionDecoration(page_action);
   if (!decoration)
     return NSZeroPoint;
 
   NSRect frame = GetPageActionFrame(page_action);
-  if (NSIsEmptyRect(frame))
+  if (NSIsEmptyRect(frame)) {
+    NOTREACHED();
     return NSZeroPoint;
+  }
 
   NSPoint bubble_point = decoration->GetBubblePointInFrame(frame);
   return [field_ convertPoint:bubble_point toView:nil];
 }
 
 NSRect LocationBarViewMac::GetBlockedPopupRect() const {
   const size_t kPopupIndex = CONTENT_SETTINGS_TYPE_POPUPS;
   const LocationBarDecoration* decoration =
       content_setting_decorations_[kPopupIndex];
   if (!decoration || !decoration->IsVisible())
@@ skipping 305 matching lines @@
 void LocationBarViewMac::UpdateChromeToMobileEnabled() {
   if (!chrome_to_mobile_decoration_.get())
     return;
 
   DCHECK(ChromeToMobileService::IsChromeToMobileEnabled());
   bool enabled = [field_ isEditable] && !toolbar_model_->input_in_progress() &&
       ChromeToMobileServiceFactory::GetForProfile(profile_)->HasMobiles();
   chrome_to_mobile_decoration_->SetVisible(enabled);
   command_updater_->UpdateCommandEnabled(IDC_CHROME_TO_MOBILE_PAGE, enabled);
 }