Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Unified Diff: chrome/browser/api/prefs/pref_member.h

Issue 10828345: Extract PrefServiceBase into chrome/browser/api. Use in api and autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/api/prefs/pref_change_registrar.cc ('k') | chrome/browser/api/prefs/pref_member.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/api/prefs/pref_member.h
diff --git a/chrome/browser/api/prefs/pref_member.h b/chrome/browser/api/prefs/pref_member.h
index 7553dce1d5d2192c472139116836573545b2491c..eb96c17ddabd32099b90934293f6d31914a44487 100644
--- a/chrome/browser/api/prefs/pref_member.h
+++ b/chrome/browser/api/prefs/pref_member.h
@@ -34,7 +34,7 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_observer.h"
-class PrefService;
+class PrefServiceBase;
namespace subtle {
@@ -81,7 +81,7 @@ class PrefMemberBase : public content::NotificationObserver {
virtual ~PrefMemberBase();
// See PrefMember<> for description.
- void Init(const char* pref_name, PrefService* prefs,
+ void Init(const char* pref_name, PrefServiceBase* prefs,
content::NotificationObserver* observer);
virtual void CreateInternal() const = 0;
@@ -110,8 +110,8 @@ class PrefMemberBase : public content::NotificationObserver {
void VerifyPref() const;
const std::string& pref_name() const { return pref_name_; }
- PrefService* prefs() { return prefs_; }
- const PrefService* prefs() const { return prefs_; }
+ PrefServiceBase* prefs() { return prefs_; }
+ const PrefServiceBase* prefs() const { return prefs_; }
virtual Internal* internal() const = 0;
@@ -119,7 +119,7 @@ class PrefMemberBase : public content::NotificationObserver {
// Ordered the members to compact the class instance.
std::string pref_name_;
content::NotificationObserver* observer_;
- PrefService* prefs_;
+ PrefServiceBase* prefs_;
protected:
bool setting_value_;
@@ -138,7 +138,7 @@ class PrefMember : public subtle::PrefMemberBase {
// Do the actual initialization of the class. |observer| may be null if you
// don't want any notifications of changes.
// This method should only be called on the UI thread.
- void Init(const char* pref_name, PrefService* prefs,
+ void Init(const char* pref_name, PrefServiceBase* prefs,
content::NotificationObserver* observer) {
subtle::PrefMemberBase::Init(pref_name, prefs, observer);
}
« no previous file with comments | « chrome/browser/api/prefs/pref_change_registrar.cc ('k') | chrome/browser/api/prefs/pref_member.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698