Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: content/renderer/render_view_impl.cc

Issue 10828342: Per-host V8 histograms. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: better version Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 3c1526682498c7356cdf5601f31cba94d9534be8..8f5089c793b20406e58a68631f57030e2e926d65 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1118,6 +1118,17 @@ void RenderViewImpl::OnNavigate(const ViewMsg_Navigate_Params& params) {
// In case LoadRequest failed before DidCreateDataSource was called.
pending_navigation_params_.reset();
+
+ // Check if all RenderViewImpls are displaying a page from the same host, and
+ // update RenderThreadImpl's view on that. If this is the only RenderViewImpl,
+ // the common host is this view's host. If there are many, check if this one
+ // shares the common host of the other RenderViewImpls. It's ok to not detect
+ // some cases where the RenderViewImpls share a common host.
Charlie Reis 2012/08/16 16:22:56 This isn't safe. You'll miss renderer-initiated n
marja 2012/08/21 15:21:15 Changed this to do the work in RenderViewImpl::did
+ RenderThreadImpl* render_thread_impl = RenderThreadImpl::current();
+ if (g_view_map.Get().size() == 1)
+ render_thread_impl->SetCommonHost(params.url.host());
+ else if (params.url.host() != render_thread_impl->CommonHost())
+ render_thread_impl->SetCommonHost(std::string());
}
bool RenderViewImpl::IsBackForwardToStaleEntry(
« content/renderer/render_thread_impl.cc ('K') | « content/renderer/render_thread_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698