Per-host V8 histograms.

content/renderer/render_thread_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
 #define CONTENT_RENDERER_RENDER_THREAD_IMPL_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 209 matching lines @@
   // by this class and must be null-tested before each use to detect context
   // loss.  The returned WeakPtr<> is only valid on the compositor thread when
   // threaded compositing is enabled.
   base::WeakPtr<WebGraphicsContext3DCommandBufferImpl> GetGpuVDAContext3D();
 
   // AudioRendererMixerManager instance which manages renderer side mixer
   // instances shared based on configured audio parameters.  Lazily created on
   // first call.
   content::AudioRendererMixerManager* GetAudioRendererMixerManager();
 
+  // Returns the current common host for RenderViewImpl's in this process, or an
+  // empty string, if there is no common host.

[Charlie Reis, 2012/08/21 22:46:49]

I think we need to say more about this in the comments and possibly improve the
names, since it's not clear that this isn't intended for general use.  (It has a
very specific meaning, which includes hard-coded sites and V8 histograms.)

Mainly, I wouldn't want other developers to think there's a supported concept of
a render process's common host and try to use it for other purposes.

[marja, 2012/08/22 14:59:31]

Removed this function; added ConvertToCustomHistogramName now that the needed
information is all inside RenderThreadImpl.

+  static std::string CommonHost();

[Charlie Reis, 2012/08/21 22:46:49]

This isn't virtual or complex, so it can probably be defined hacker_style() and
defined inline.

[marja, 2012/08/22 14:59:31]

This no longer exists either.

+
+  // Used for updating the information on which is the common host which all
+  // RenderView's share (if any). If there is no common host, this function is
+  // called with an empty string.
+  static void SetCommonHost(const std::string& host);
+
  private:
   virtual bool OnControlMessageReceived(const IPC::Message& msg) OVERRIDE;
 
   void Init();
 
   void OnSetZoomLevelForCurrentURL(const std::string& host, double zoom_level);
   void OnSetCSSColors(const std::vector<CSSColors::CSSColorMapping>& colors);
   void OnCreateNewView(const ViewMsg_New_Params& params);
   void OnTransferBitmap(const SkBitmap& bitmap, int resource_id);
   void OnPurgePluginListCache(bool reload_pages);
@@ skipping 60 matching lines @@
   ObserverList<content::RenderProcessObserver> observers_;
 
   scoped_ptr<WebGraphicsContext3DCommandBufferImpl> gpu_vda_context3d_;
 
   scoped_ptr<content::AudioRendererMixerManager> audio_renderer_mixer_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderThreadImpl);
 };
 
 #endif  // CONTENT_RENDERER_RENDER_THREAD_IMPL_H_