Per-host V8 histograms.

content/renderer/render_thread_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_thread_impl.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <vector>
@@ skipping 139 matching lines @@
     return true;
   }
 
  private:
   std::string host_;
   double zoom_level_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewZoomer);
 };
 
-}  // namespace
+std::string HostToCustomPage(const std::string& host) {
+  if (host == "mail.google.com")
+    return ".gmail";
+  if (host == "docs.google.com" || host == "drive.google.com")
+    return ".docs";
+  if (host == "plus.google.com")
+    return ".plus";
+  return "";
+}
 
-static void* CreateHistogram(
+std::string common_host;

[Charlie Reis, 2012/08/21 22:46:49]

These are globals and should start with g_, right?  Actually, can we avoid
having them as globals?  (There's only one render thread per process, right?)

[marja, 2012/08/22 14:59:31]

They're inside an unnamed namespace, so only visible in this file and thus not
globals.

But I changed them to be member variables in the RenderThread instead.

+std::string custom_page;
+base::LazyInstance<std::set<std::string> > custom_histograms =
+    LAZY_INSTANCE_INITIALIZER;
+
+void InitializeCustomHistograms() {
+  std::set<std::string>* histograms = custom_histograms.Pointer();
+  if (!histograms->empty())
+    return;
+  histograms->insert("V8.GCCompactor");
+  histograms->insert("V8.GCScavenger");
+  histograms->insert("V8.GCContext");
+  histograms->insert("V8.Parse");
+  histograms->insert("V8.ParseLazy");
+  histograms->insert("V8.PreParse");
+  histograms->insert("V8.Compile");
+  histograms->insert("V8.CompileEval");
+  histograms->insert("V8.CompileLazy");
+  histograms->insert("V8.MemoryExternalFragmentationTotal");
+  histograms->insert("V8.MemoryExternalFragmentationOldPointerSpace");
+  histograms->insert("V8.MemoryExternalFragmentationOldDataSpace");
+  histograms->insert("V8.MemoryExternalFragmentationCodeSpace");
+  histograms->insert("V8.MemoryExternalFragmentationMapSpace");
+  histograms->insert("V8.MemoryExternalFragmentationCellSpace");
+  histograms->insert("V8.MemoryExternalFragmentationLoSpace");
+}
+
+void* CreateHistogram(
     const char *name, int min, int max, size_t buckets) {
   if (min <= 0)
     min = 1;
+  InitializeCustomHistograms();
+  std::string histogram_name(name);
+  if (custom_histograms.Get().find(histogram_name) !=
+      custom_histograms.Get().end())
+    histogram_name += custom_page;
   base::Histogram* histogram = base::Histogram::FactoryGet(
-      name, min, max, buckets, base::Histogram::kUmaTargetedHistogramFlag);
+      histogram_name, min, max, buckets,
+      base::Histogram::kUmaTargetedHistogramFlag);
   return histogram;
 }
 
-static void AddHistogramSample(void* hist, int sample) {
+void AddHistogramSample(void* hist, int sample) {
   base::Histogram* histogram = static_cast<base::Histogram*>(hist);
   histogram->Add(sample);
 }
 
+}  // namespace
+
 RenderThreadImpl* RenderThreadImpl::current() {
   return lazy_tls.Pointer()->Get();
 }
 
 // When we run plugins in process, we actually run them on the render thread,
 // which means that we need to make the render thread pump UI events.
 RenderThreadImpl::RenderThreadImpl() {
   Init();
 }
 
@@ skipping 586 matching lines @@
 RenderThreadImpl::GetAudioRendererMixerManager() {
   if (!audio_renderer_mixer_manager_.get()) {
     audio_renderer_mixer_manager_.reset(new AudioRendererMixerManager(
         audio_hardware::GetOutputSampleRate(),
         audio_hardware::GetOutputBufferSize()));
   }
 
   return audio_renderer_mixer_manager_.get();
 }
 
+// static
+std::string RenderThreadImpl::CommonHost() {
+  return common_host;
+}
+
+// static
+void RenderThreadImpl::SetCommonHost(const std::string& host) {
+  if (host != common_host) {

[Charlie Reis, 2012/08/21 22:46:49]

Can we move some of the logic into here rather than at the call site?  At the
moment, we're relying on every caller to carefully check if there's still a
common host.  Seems like it might be a better contract to let this class listen
for the hosts that are present and decide if there's a common one or not.

[marja, 2012/08/22 14:59:31]

Done: Moved the logic to RenderThreadImpl. RenderViewImpl just calls
RenderViewNavigatedToHost in RenderViewImpl::didCommitProvisionalLoad; is that
ok?

[Charlie Reis, 2012/08/22 23:09:59]

Yes, much better, thanks.

+    common_host = host;
+    custom_page = HostToCustomPage(host);
+    v8::V8::SetCreateHistogramFunction(CreateHistogram);
+  }
+}
+
 #if defined(OS_WIN)
 void RenderThreadImpl::PreCacheFont(const LOGFONT& log_font) {
   Send(new ChildProcessHostMsg_PreCacheFont(log_font));
 }
 
 void RenderThreadImpl::ReleaseCachedFonts() {
   Send(new ChildProcessHostMsg_ReleaseCachedFonts());
 }
 
 #endif  // OS_WIN
@@ skipping 248 matching lines @@
 
 scoped_refptr<base::MessageLoopProxy>
 RenderThreadImpl::GetFileThreadMessageLoopProxy() {
   DCHECK(message_loop() == MessageLoop::current());
   if (!file_thread_.get()) {
     file_thread_.reset(new base::Thread("Renderer::FILE"));
     file_thread_->Start();
   }
   return file_thread_->message_loop_proxy();
 }