Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chromeos/network/network_sms_handler_unittest.cc

Issue 10828267: Add kSmsTestMessages switch to sms handler unititest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/network_sms_handler_unittest.cc
diff --git a/chromeos/network/network_sms_handler_unittest.cc b/chromeos/network/network_sms_handler_unittest.cc
index 0e5fd2400665ea2a96b2efd1a1850e6037ba8247..5ea94f86fa81c90ac811493b2c7e0f82633e950e 100644
--- a/chromeos/network/network_sms_handler_unittest.cc
+++ b/chromeos/network/network_sms_handler_unittest.cc
@@ -7,9 +7,11 @@
#include <set>
#include <string>
+#include "base/command_line.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/chromeos_switches.h"
hashimoto 2012/08/12 15:00:09 nit: This line should come before chromeos/dbus
stevenjb 2012/08/13 16:46:45 Done.
#include "testing/gtest/include/gtest/gtest.h"
namespace chromeos {
@@ -63,6 +65,9 @@ class NetworkSmsHandlerTest : public testing::Test {
};
TEST_F(NetworkSmsHandlerTest, SmsHandlerDbusStub) {
+ CommandLine* command_line = CommandLine::ForCurrentProcess();
+ command_line->AppendSwitch(chromeos::switches::kSmsTestMessages);
hashimoto 2012/08/12 15:00:09 Please add a brief description comment about why t
stevenjb 2012/08/13 16:46:45 Done.
+
// This relies on the stub dbus implementations for FlimflamManagerClient,
// FlimflamDeviceClient, GsmSMSClient, ModemMessagingClient and SMSClient.
// Initialize a sms handler. The stub dbus clients will not send the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698