Clean up logging for push_notifications_*.cc

jingle/notifier/listener/notification_defines.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/notifier/listener/notification_defines.h"
 
 #include <cstddef>
 
+#include "base/base64.h"
+#include "base/logging.h"
+#include "base/string_util.h"
+
 namespace notifier {
 
 Subscription::Subscription() {}
 Subscription::~Subscription() {}
 
 bool Subscription::Equals(const Subscription& other) const {
   return channel == other.channel && from == other.from;
 }
 
 namespace {
@@ skipping 34 matching lines @@
 Notification::~Notification() {}
 
 bool Notification::Equals(const Notification& other) const {
   return
       channel == other.channel &&
       data == other.data &&
       RecipientListsEqual(recipients, other.recipients);
 }
 
 std::string Notification::ToString() const {
-  return "{ channel: \"" + channel + "\", data: \"" + data + "\" }";
+  std::string printable_data;
+  if (IsStringASCII(data)) {
+    printable_data = data;
+  } else {
+    CHECK(base::Base64Encode(data, &printable_data));

[rlarocque, 2012/08/10 20:58:38]

If this is supposed to be semi-human-readable binary data, could we print it in
hex?  I can't learn anything by reading base64.  Hex is a lot easier to read at
a glance.

[akalin, 2012/08/13 20:24:15]

Done.

+  }
+  return "{ channel: \"" + channel + "\", data: \"" + printable_data + "\" }";
 }
 
 }  // namespace notifier