Extensions Docs Server: Efficient MemcacheFileSystem

chrome/common/extensions/docs/server2/file_system.py

Index: chrome/common/extensions/docs/server2/file_system.py
diff --git a/chrome/common/extensions/docs/server2/file_system.py b/chrome/common/extensions/docs/server2/file_system.py
index 873cdbffa3d3650fe96d504c2265809ae8c7b071..8ed051bf706c98089166ece978db72228f1f2b7a 100644
--- a/chrome/common/extensions/docs/server2/file_system.py
+++ b/chrome/common/extensions/docs/server2/file_system.py
@@ -18,8 +18,9 @@ class FileSystem(object):
   class StatInfo(object):
     """The result of calling Stat on a FileSystem.
     """
-    def __init__(self, version):
+    def __init__(self, version, child_versions):
       self.version = version
+      self.child_versions = child_versions
 
   def Read(self, paths, binary=False):
     """Reads each file in paths and returns a dictionary mapping the path to the
@@ -38,7 +39,9 @@ class FileSystem(object):
     return self.Read([path]).Get()[path]
 
   def Stat(self, path):
-    """Gets the version number of |path| if it is a directory, or the parent
-    directory if it is a file.
+    """Returns a |StatInfo| object containing the version of the parent
+    directory if a file is specified, or the directory itself if a directory is
+    specified. The |StatInfo| object also has the versions of all the children
+    of the directory.

[not at google - send to devlin, 2012/08/10 06:42:24]

This would be a strange interface.

If a file, it should return a StatInfo for the file. An implementation might end
up getting the stat for the whole directory the pulling just that single file
out (inefficient but whatever).

(If callers want the directory's stat, they should figure out what the directory
is then Stat that).

If a directory... what you've written is correct.

[cduvall, 2012/08/11 00:15:23]

Done.

     """
     raise NotImplementedError()