Extensions Docs Server: Efficient MemcacheFileSystem

chrome/common/extensions/docs/server2/local_file_system.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 import file_system
 from future import Future
 
 class LocalFileSystem(file_system.FileSystem):
@@ skipping 34 matching lines @@
 
   def Read(self, paths, binary=False):
     result = {}
     for path in paths:
       if path.endswith('/'):
         result[path] = self._ListDir(self._ConvertToFilepath(path))
       else:
         result[path] = self._ReadFile(self._ConvertToFilepath(path), binary)
     return Future(value=result)
 
+  def _CreateStatInfo(self, path):
+    versions = dict((filename, os.stat(os.path.join(path, filename)).st_mtime)
+                    for filename in os.listdir(path))
+    return self.StatInfo(os.stat(path).st_mtime, versions)
+
   def Stat(self, path):
     try:
-      return self.StatInfo(
-          os.stat(os.path.join(self._base_path, path)).st_mtime)
+      if not path.endswith('/'):
+        return self.StatInfo(
+            os.stat(os.path.join(self._base_path, path)).st_mtime, {})

[not at google - send to devlin, 2012/08/13 05:34:15]

This logic is basically repeated in _CreateStatInfo, so put in there? This
method:

return self._CreateStatInfo(...)

above:

def _CreateStatInfo(self, path):
  def Mtime(path):
    return os.stat(path).st_mtime

  if path.endswith('/'):
    versions = dict((filename, Mtime(os.path.join(path, filename))
                     for filename in os.listdir(path))
  else:
    # note to cduvall: prefer None to {} here.
    versions = None
  return self.StatInfo(Mtime(path), versions)

[cduvall, 2012/08/13 19:45:45]

Done.

+      return self._CreateStatInfo(os.path.join(self._base_path, path))
     except OSError:
       raise file_system.FileNotFoundError(path)
-