chrome/browser/ui/views/extensions/extension_install_dialog_view.cc - Issue 10828198: Update oauth strings for extension install UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

Issue 10828198: Update oauth strings for extension install UI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix compile Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

index ed73aae176217880490ab28827f3b21d8e36e23e..51dedde2558084e003df70a9996c2d05fa8d037e 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc

@@ -240,8 +240,9 @@ ExtensionInstallDialogView::ExtensionInstallDialogView(

int column_set_id = 0;

views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);

- int left_column_width = prompt.GetPermissionCount() > 0 ?

- kPermissionsLeftColumnWidth : kNoPermissionsLeftColumnWidth;

+ int left_column_width =

+ prompt.GetPermissionCount() + prompt.GetOAuthIssueCount() > 0 ?

Peter Kasting 2012/08/15 21:41:49 Nit: I suggest parens around addition

+ kPermissionsLeftColumnWidth : kNoPermissionsLeftColumnWidth;

if (is_bundle_install())

left_column_width = kBundleLeftColumnWidth;

« no previous file with comments | « chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc ('k') | no next file » | no next file with comments »