Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.cc

Issue 10828172: Allow platform apps to respond to Web Intents (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adds basic test Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.cc b/chrome/browser/ui/intents/web_intent_picker_controller.cc
index 64fdf2a93a62902570a86309b4ade165b9941808..92a37399251ab327d99d70a3da13f12e12070ae4 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.cc
@@ -295,11 +295,7 @@ void WebIntentPickerController::OnServiceChosen(
const extensions::Extension* extension = service->GetInstalledApp(url);
if (extension && extension->is_platform_app()) {
extensions::LaunchPlatformAppWithWebIntent(tab_contents_->profile(),
- extension, intents_dispatcher_->GetIntent());
- // TODO(benwells): hook up return pathway to allow platform app to post
- // success or failure.
- intents_dispatcher_->SendReplyMessage(
- webkit_glue::WEB_INTENT_REPLY_SUCCESS, string16());
+ extension, intents_dispatcher_, tab_contents_->web_contents());
ClosePicker();
return;
}

Powered by Google App Engine
This is Rietveld 408576698