media galleries config dialog on views

chrome/browser/ui/views/extensions/media_galleries_dialog_views.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_MEDIA_GALLERIES_DIALOG_VIEWS_H_
+#define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_MEDIA_GALLERIES_DIALOG_VIEWS_H_
+
+#include <map>
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/media_gallery/media_galleries_dialog_controller.h"
+#include "ui/views/window/dialog_delegate.h"
+
+class ConstrainedWindowViews;
+
+namespace views {
+class Checkbox;
+}
+
+namespace chrome {
+
+// The media galleries configuration view for Views. It will immediately show
+// upon construction.
+class MediaGalleriesDialogViews : public MediaGalleriesDialog,
+                                  public views::DialogDelegate,
+                                  public views::ButtonListener {
+ public:
+  explicit MediaGalleriesDialogViews(
+      MediaGalleriesDialogController* controller);
+  virtual ~MediaGalleriesDialogViews();
+
+  // MediaGalleriesDialog implementation:
+  virtual void UpdateGallery(const MediaGalleryPrefInfo* gallery,
+                             bool permitted) OVERRIDE;
+
+  // views::DialogDelegate implementation:
+  virtual void DeleteDelegate() OVERRIDE;
+  virtual views::Widget* GetWidget() OVERRIDE;
+  virtual const views::Widget* GetWidget() const OVERRIDE;
+  virtual views::View* GetContentsView() OVERRIDE;

[Peter Kasting, 2012/08/14 18:44:01]

Nit: Now that you've moved these declarations, also reorder the definitions to
match.

+  virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
+  virtual bool IsDialogButtonEnabled(ui::DialogButton button) const OVERRIDE;
+  virtual bool Cancel() OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+
+  // views::ButtonListener implementation:
+  virtual void ButtonPressed(views::Button* sender,
+                             const ui::Event& event) OVERRIDE;
+
+ private:
+  typedef std::map<const MediaGalleryPrefInfo*, views::Checkbox*> CheckboxMap;
+
+  void InitChildViews();
+
+  // Adds a checkbox or updates an existing checkbox. Returns true if a new one
+  // was added.
+  bool AddOrUpdateGallery(const MediaGalleryPrefInfo* gallery,
+                          bool permitted);
+
+  MediaGalleriesDialogController* controller_;
+
+  // The constrained window (a weak pointer).
+  ConstrainedWindowViews* window_;
+
+  // The contents of the dialog. This is a weak pointer, it is owned by its
+  // its parent view.

[Peter Kasting, 2012/08/14 18:44:01]

Nit: its its

It's not actually obvious what the parent of this is.  I think it's owned by
|window_|'s RootView.  Maybe the comment here can say "The contents of the
dialog.  Owned by |window_|'s RootView."?

[Evan Stade, 2012/08/14 21:07:28]

you passed the test!

+  views::View* contents_;
+
+  // A map from media gallery to views::Checkbox view.
+  CheckboxMap checkbox_map_;
+
+  views::View* checkbox_container_;
+  views::Button* add_gallery_;
+
+  // This tracks whether the confirm button can be clicked. It starts as false
+  // if no checkboxes are ticked. After there is any interaction, or some
+  // checkboxes start checked, this will be true.
+  bool confirm_available_;
+
+  // True if the user has pressed accept.
+  bool accepted_;
+
+  DISALLOW_COPY_AND_ASSIGN(MediaGalleriesDialogViews);
+};
+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_MEDIA_GALLERIES_DIALOG_VIEWS_H_