[Chromoting] Move CreateSessionToken() next to launch process utilities.

remoting/host/win/launch_process_with_token.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_WIN_LAUNCH_PROCESS_WITH_TOKEN_H_
 #define REMOTING_HOST_WIN_LAUNCH_PROCESS_WITH_TOKEN_H_
 
 #include <windows.h>
 #include <string>
 
 #include "base/file_path.h"
 #include "base/process_util.h"
+#include "base/win/scoped_handle.h"

[Wez, 2012/08/03 20:56:06]

nit: Forward-declare since you don't actually need to know the internals of
ScopedHandle in this header?

[alexeypa (please no reviews), 2012/08/03 21:40:39]

ScopedHandle is a template specialization which cannot be forward-declared.
However we don't really need ScopedHandle here at all.

[Wez, 2012/08/06 17:41:04]

Personally I'd leave the API using ScopedHandle, at the cost of requiring this
include, to keep HANDLE ownership clear.

[alexeypa (please no reviews), 2012/08/06 17:48:36]

Getting rid of include wasn't the reason to switch to HANDLE*. ScopedHandle
designed to pass and get ownership via Take() and Receive(). The code looks more
consistent and cleaner if they used. It starts getting uglier once I try passing
ScopedHandle instead of a naked type. ScopedHandle.Pass() would be handy, but
given the lack of it I prefer to stick to Take() and Release().

[Wez, 2012/08/06 17:57:30]

Right; Pass() is syntactic sugar for Set(Take()); having in-parameters be
HANDLEs, with the assumption being that the function does not "own" HANDLEs is
fine, but for an out-parameter it feels clearer to use ScopedHandle* similarly
to the way we use scoped_ptr<>*.

 
 namespace remoting {
 
+// Creates a copy of the current process token for the given |session_id| so
+// it can be used to launch a process in that session.
+bool CreateSessionToken(uint32 session_id, base::win::ScopedHandle* token_out);
+
 // Launches |binary| in the security context of the user represented by
 // |user_token|. The session ID specified by the token is respected as well.
 bool LaunchProcessWithToken(const FilePath& binary,
                             const std::wstring& command_line,
                             HANDLE user_token,
                             base::Process* process_out);
 
 } // namespace remoting
 
 #endif  // REMOTING_HOST_WIN_LAUNCH_PROCESS_WITH_TOKEN_H_