Upstream about:welcome page for Android.

chrome/browser/browser_about_handler.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
 #define CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 61 matching lines @@
   friend struct DefaultSingletonTraits<AboutTcmallocOutputs>;
 
   DISALLOW_COPY_AND_ASSIGN(AboutTcmallocOutputs);
 };
 
 // Glue between the callback task and the method in the singleton.
 void AboutTcmallocRendererCallback(base::ProcessId pid,
                                    const std::string& output);
 #endif  // defined(USE_TCMALLOC)
 
+#if defined(OS_ANDROID)
+class AboutAndroidApp {

[Evan Stade, 2012/08/03 17:58:01]

why is this class in this file?

you need to document this class.

+ public:
+  typedef std::string (*Callback)();
+
+  static std::string GetAppLabel() {
+    return label_getter_ != NULL ? label_getter_() : "";
+  }
+
+  static std::string GetAppVersionName() {
+    return version_name_getter_ != NULL ? version_name_getter_() : "";
+  }
+
+  static std::string GetAppVersionCode() {
+    return version_code_getter_ != NULL ? version_code_getter_() : "";
+  }
+
+  static void RegisterGetters(Callback label_getter,
+          Callback version_name_getter, Callback version_code_getter);

[Evan Stade, 2012/08/03 17:58:01]

too much indent

+
+ private:
+  static Callback label_getter_;
+  static Callback version_name_getter_;
+  static Callback version_code_getter_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(AboutAndroidApp);
+};
+#endif
+
 #endif  // CHROME_BROWSER_BROWSER_ABOUT_HANDLER_H_