SPDY: WriteHeaders should not invoke OnDataSent callback

net/spdy/spdy_stream.h

Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index 0e383b321dbd186ae362879b285aa94d689df39f..9d0ccebab6e6cf0662cac2178857af6d26795b56 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -71,6 +71,9 @@ class NET_EXPORT_PRIVATE SpdyStream
                                    base::Time response_time,
                                    int status) = 0;
 
+    // Called when a HEADERS frame is sent.
+    virtual void OnHeadersSent() = 0;
+
     // Called when data is received.
     virtual void OnDataReceived(const char* data, int length) = 0;
 
@@ -89,14 +92,14 @@ class NET_EXPORT_PRIVATE SpdyStream
   };
 
   // Indicates pending frame type.
-  enum PendingFrameType {
-    TYPE_HEADER,
+  enum FrameType {
+    TYPE_HEADERS,
     TYPE_DATA
   };
 
   // Structure to contains pending frame information.
   typedef struct {
-    PendingFrameType type;
+    FrameType type;
     union {
       SpdyHeaderBlock* header_block;
       SpdyDataFrame* data_frame;
@@ -366,6 +369,8 @@ class NET_EXPORT_PRIVATE SpdyStream
 
   std::list<PendingFrame> pending_frames_;
 
+  std::list<FrameType> waiting_completions_;

[Ryan Hamilton, 2012/08/13 17:10:02]

nit: Please add a comment that describes the difference between pending_frames_
and waiting_completions_. 

[Takashi Toyoshima, 2012/08/14 09:14:02]

Done.

+
   State io_state_;
 
   // Since we buffer the response, we also buffer the response status.