net/spdy/spdy_proxy_client_socket.cc - Issue 10828129: SPDY: WriteHeaders should not invoke OnDataSent callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_proxy_client_socket.cc

Issue 10828129: SPDY: WriteHeaders should not invoke OnDataSent callback (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add check for OnHeadersSent in tests Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_proxy_client_socket.cc

diff --git a/net/spdy/spdy_proxy_client_socket.cc b/net/spdy/spdy_proxy_client_socket.cc

index 251ada249290936d98e08922681be383246551b4..925e2c8c4d4fcd7527f25454286d60e6acf676ad 100644

--- a/net/spdy/spdy_proxy_client_socket.cc

+++ b/net/spdy/spdy_proxy_client_socket.cc

@@ -488,6 +488,11 @@ int SpdyProxyClientSocket::OnResponseReceived(

return OK;

}

+void SpdyProxyClientSocket::OnHeadersSent() {

+ // Proxy client sockets don't send any HEADERS frame.

+ NOTREACHED();

// Called when data is received.

void SpdyProxyClientSocket::OnDataReceived(const char* data, int length) {

if (length > 0) {