Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6564)

Unified Diff: chromeos/dbus/ibus/ibus_lookup_table.cc

Issue 10828114: Fix missing default values. (Closed) Base URL: http://git.chromium.org/chromium/src.git@ibus_module_revise
Patch Set: Add default value for initial page size constant Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_property.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/ibus/ibus_lookup_table.cc
diff --git a/chromeos/dbus/ibus/ibus_lookup_table.cc b/chromeos/dbus/ibus/ibus_lookup_table.cc
index 07db8fbc77dfe43fa4656b5d5af39be376cb0ba3..0c732451d920d39cb818e77b8ed6cd1b9b3e90cc 100644
--- a/chromeos/dbus/ibus/ibus_lookup_table.cc
+++ b/chromeos/dbus/ibus/ibus_lookup_table.cc
@@ -14,6 +14,11 @@ namespace chromeos {
// TODO(nona): Remove ibus namespace after complete libibus removal.
namespace ibus {
+namespace {
+// The default entry number of a page in IBusLookupTable.
+const int kDefaultPageSize = 9;
+} // namespace
+
void AppendIBusLookupTable(const IBusLookupTable& table,
dbus::MessageWriter* writer) {
IBusObjectWriter ibus_lookup_table_writer("IBusLookupTable",
@@ -197,7 +202,7 @@ bool PopIBusLookupTable(dbus::MessageReader* reader, IBusLookupTable* table) {
///////////////////////////////////////////////////////////////////////////////
// IBusLookupTable
IBusLookupTable::IBusLookupTable()
- : page_size_(0),
+ : page_size_(kDefaultPageSize),
cursor_position_(0),
is_cursor_visible_(true),
orientation_(IBUS_LOOKUP_TABLE_ORIENTATION_HORIZONTAL) {
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698