Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Side by Side Diff: chromeos/dbus/ibus/ibus_lookup_table.cc

Issue 10828114: Fix missing default values. (Closed) Base URL: http://git.chromium.org/chromium/src.git@ibus_module_revise
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_property.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/ibus/ibus_lookup_table.h" 5 #include "chromeos/dbus/ibus/ibus_lookup_table.h"
6 6
7 #include <string> 7 #include <string>
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "dbus/message.h" 9 #include "dbus/message.h"
10 #include "chromeos/dbus/ibus/ibus_text.h" 10 #include "chromeos/dbus/ibus/ibus_text.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 return false; 190 return false;
191 } 191 }
192 (*candidates)[i].label = label_text; 192 (*candidates)[i].label = label_text;
193 } 193 }
194 return true; 194 return true;
195 } 195 }
196 196
197 /////////////////////////////////////////////////////////////////////////////// 197 ///////////////////////////////////////////////////////////////////////////////
198 // IBusLookupTable 198 // IBusLookupTable
199 IBusLookupTable::IBusLookupTable() 199 IBusLookupTable::IBusLookupTable()
200 : page_size_(0), 200 : page_size_(9),
satorux1 2012/08/01 19:56:02 please add some comment why 9 was chosen here. You
Seigo Nonaka 2012/08/02 04:03:50 Done.
201 cursor_position_(0), 201 cursor_position_(0),
202 is_cursor_visible_(true), 202 is_cursor_visible_(true),
203 orientation_(IBUS_LOOKUP_TABLE_ORIENTATION_HORIZONTAL) { 203 orientation_(IBUS_LOOKUP_TABLE_ORIENTATION_HORIZONTAL) {
204 } 204 }
205 205
206 IBusLookupTable::~IBusLookupTable() { 206 IBusLookupTable::~IBusLookupTable() {
207 } 207 }
208 208
209 } // namespace ibus 209 } // namespace ibus
210 } // namespace chromeos 210 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_property.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698