Support serial number requests in variations service.

chrome/browser/metrics/variations_service.h

Index: chrome/browser/metrics/variations_service.h
===================================================================
--- chrome/browser/metrics/variations_service.h	(revision 149502)
+++ chrome/browser/metrics/variations_service.h	(working copy)
@@ -40,7 +40,8 @@
   bool CreateTrialsFromSeed(PrefService* local_prefs);
 
   // Calls FetchVariationsSeed once and repeats this periodically. See
-  // implementation for details on the period.
+  // implementation for details on the period. Must be called after
+  // |CreateTrialsFromSeed|.
   void StartRepeatedVariationsSeedFetch();
 
   // Starts the fetching process once, where |OnURLFetchComplete| is called with
@@ -127,9 +128,16 @@
   // The URL to use for querying the variations server.
   GURL variations_server_url_;
 
+  // Cached serial number from the most recently fetched variations seed.
+  std::string variations_serial_number_;
+
+  // Tracks whether |CreateTrialsFromSeed| has been called, to ensure that
+  // it gets called prior to |StartRepeatedVariationsSeedFetch|.
+  bool create_trials_from_seed_called_;

[Ilya Sherman, 2012/08/02 23:40:49]

nit: This seems a little hacky.  Is there any way to more directly check whether
CreateTrialsFromSeed() initialized whatever data you're expecting to be
initialized?

[Alexei Svitkine (slow), 2012/08/02 23:51:02]

I can't think of a good way - the issue is that it's perfectly valid for
CreateTrialsFromSeed() to return early if there's no seed stored in prefs yet.

+
   // The timer used to repeatedly ping the server. Keep this as an instance
   // member so if VariationsService goes out of scope, the timer is
-  // automatically cancelled.
+  // automatically canceled.
   base::RepeatingTimer<VariationsService> timer_;
 };