chrome/browser/chromeos/extensions/file_browser_private_api.cc - Issue 10828086: File Manager: fix an unsafe const reference (intermittent crash).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_browser_private_api.cc

Issue 10828086: File Manager: fix an unsafe const reference (intermittent crash). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add OWNER for chrome/browser/chromeos/extensions. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/extensions/file_browser_private_api.cc

diff --git a/chrome/browser/chromeos/extensions/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_browser_private_api.cc

index b4f46d81609fc82c7505cdb0bdef08e49fcf14e3..99dd321632bd39abd6adf71d4e2ba619edc1501b 100644

--- a/chrome/browser/chromeos/extensions/file_browser_private_api.cc

+++ b/chrome/browser/chromeos/extensions/file_browser_private_api.cc

@@ -1152,8 +1152,7 @@ void AddMountFunction::GetLocalPathsResponseOnUIThread(

}

const FilePath& source_path = files[0].local_path;

- const FilePath::StringType& display_name =

- files[0].file_path.BaseName().value();

+ const FilePath::StringType& display_name = files[0].display_name;

// Check if the source path is under GData cache directory.

gdata::GDataSystemService* system_service =

gdata::GDataSystemServiceFactory::GetForProfile(profile_);