Fix a renderer crash when media elements get deleted

webkit/media/android/webmediaplayer_android.cc

Index: webkit/media/android/webmediaplayer_android.cc
diff --git a/webkit/media/android/webmediaplayer_android.cc b/webkit/media/android/webmediaplayer_android.cc
index 6670ded56ec68e17ad375d8a1c41bf6c8f49f0c7..6fad668ec0240d87d2e09995991babcd19006c77 100644
--- a/webkit/media/android/webmediaplayer_android.cc
+++ b/webkit/media/android/webmediaplayer_android.cc
@@ -92,6 +92,9 @@ WebMediaPlayerAndroid::~WebMediaPlayerAndroid() {
   if (manager_)
     manager_->UnregisterMediaPlayer(player_id_);
 
+  if (stream_id_)

[Ami GONE FROM CHROMIUM, 2012/07/30 23:09:36]

Huh; I didn't realize there's only one VideoFrame in the android port (in the
media/ pipeline there are 4 in flight during playback).  Is there any reason
DestroyStreamTexture shouldn't be inlined into the dtor?
Further is there any reason the CreateStreamTexture call needs to be lazy
instead of inlining it into the ctor?  It seems like that'd be much clearer to
read...

[qinmin, 2012/07/31 22:07:52]

We had some concerns previously on memory usage of surface texture. The android
team has recently confirmed with us that no buffer will be allocated if surface
texture is not being used. So moving CreateStreamTexture to ctor makes sense
now. 
Modified the code to make stream_id_ and texture_id_ initialized in ctor, and
deletion happens in dtor. video_frame_ will be constructed once its size is
known.
On 2012/07/30 23:09:36, Ami Fischman wrote:

+     DestroyStreamTexture();
+
   if (main_loop_)
     main_loop_->RemoveDestructionObserver(this);
 }
@@ -543,8 +546,7 @@ void WebMediaPlayerAndroid::CreateStreamTexture() {
         texture_size_.height,
         base::TimeDelta(),
         base::TimeDelta(),
-        base::Bind(&WebMediaPlayerAndroid::DestroyStreamTexture,
-                   base::Unretained(this)))));
+        base::Closure())));
 }
 
 void WebMediaPlayerAndroid::DestroyStreamTexture() {