Makes ui::GetSupportedScaleFactors available on platforms other than Mac

Makes ui::GetSupportedScaleFactors available on platforms other than Mac.

BUG=None
TEST=Compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150814

[pkotwicz, 2012-07-27 14:54:19]

Makes ui::GetSupportedScaleFactors available on platforms other than Mac.
I need this for:
http://codereview.chromium.org/10783015/

[oshima, 2012-08-07 02:14:47]

https://chromiumcodereview.appspot.com/10828052/diff/1/ui/gfx/image/image_uni...
File ui/gfx/image/image_unittest_util.h (left):

https://chromiumcodereview.appspot.com/10828052/diff/1/ui/gfx/image/image_uni...
ui/gfx/image/image_unittest_util.h:26: #endif
I wonder why we need this. Maybe we no longer need this?

[pkotwicz, 2012-08-07 14:53:11]

Changes as requested.

We still need SetSupportedScaleFactorsTo1xAnd2x
I modified GetSupportedScaleFactorsInternal to what it should be.
In particular Macs which are older than Lion do not support 2x.

[sky, 2012-08-07 19:38:47]

http://codereview.chromium.org/10828052/diff/3001/ui/base/layout.cc
File ui/base/layout.cc (right):

http://codereview.chromium.org/10828052/diff/3001/ui/base/layout.cc#newcode150
ui/base/layout.cc:150: supported_scale_factors.clear();
supported_scale_factors = scale_factors;

http://codereview.chromium.org/10828052/diff/3001/ui/base/resource/resource_b...
File ui/base/resource/resource_bundle_mac.mm (right):

http://codereview.chromium.org/10828052/diff/3001/ui/base/resource/resource_b...
ui/base/resource/resource_bundle_mac.mm:63: if
(std::find(supported_scale_factors.begin(), supported_scale_factors.end(),
Having to do a find is a bit painful. Are we going to need this check in a
number of places? If so, an IsSupportesScaled seems better.

[pkotwicz, 2012-08-07 21:40:11]

Changes as requested

[sky, 2012-08-07 22:39:54]

http://codereview.chromium.org/10828052/diff/3001/ui/base/layout.cc
File ui/base/layout.cc (right):

http://codereview.chromium.org/10828052/diff/3001/ui/base/layout.cc#newcode150
ui/base/layout.cc:150: supported_scale_factors.clear();
On 2012/08/07 19:38:47, sky wrote:
> supported_scale_factors = scale_factors;

I think you missed this one.

[oshima, 2012-08-08 01:02:14]

http://codereview.chromium.org/10828052/diff/6002/ui/base/layout.cc
File ui/base/layout.cc (right):

http://codereview.chromium.org/10828052/diff/6002/ui/base/layout.cc#newcode89
ui/base/layout.cc:89: // let the UI framework decide which one to use.
On Mac OSX Lion

http://codereview.chromium.org/10828052/diff/6002/ui/base/resource/resource_b...
File ui/base/resource/resource_bundle_aurax11.cc (right):

http://codereview.chromium.org/10828052/diff/6002/ui/base/resource/resource_b...
ui/base/resource/resource_bundle_aurax11.cc:29: // TODO(pkotwicz): Check
ui::GetSupportedScaleFactors().
This will be dynamic (that is, it loads upon request)

[pkotwicz, 2012-08-08 14:43:57]

Scott, sorry I missed that one =(

Changes as requested by Scott and Oshima

[pkotwicz, 2012-08-08 14:44:09]

http://codereview.chromium.org/10828052/diff/6002/ui/base/layout.cc
File ui/base/layout.cc (right):

http://codereview.chromium.org/10828052/diff/6002/ui/base/layout.cc#newcode89
ui/base/layout.cc:89: // let the UI framework decide which one to use.
Moved the comment back into resource_bundle_mac.mm

[sky, 2012-08-08 14:50:52]

LGTM

[oshima_google, 2012-08-08 14:56:58]

lgtm

[commit-bot: I haz the power, 2012-08-08 16:13:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10828052/8004

[commit-bot: I haz the power, 2012-08-08 16:13:49]

Failed to apply patch for ui/base/resource/resource_bundle_mac.mm:
While running patch -p1 --forward --force;
patching file ui/base/resource/resource_bundle_mac.mm
Hunk #1 FAILED at 56.
1 out of 1 hunk FAILED -- saving rejects to file
ui/base/resource/resource_bundle_mac.mm.rej

[commit-bot: I haz the power, 2012-08-08 17:14:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10828052/1007

[commit-bot: I haz the power, 2012-08-08 17:29:03]

Try job failure for 10828052-1007 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-09 15:16:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10828052/1011

[commit-bot: I haz the power, 2012-08-09 16:38:51]

Change committed as 150814