Add DeviceSettingsService.

chrome/browser/policy/cloud_policy_validator_unittest.cc

Index: chrome/browser/policy/cloud_policy_validator_unittest.cc
diff --git a/chrome/browser/policy/cloud_policy_validator_unittest.cc b/chrome/browser/policy/cloud_policy_validator_unittest.cc
index ee767278e9325bb3a2cc02af99b151a80cdb6c98..1b3137e68529252341369964b7c3f1f51826d081 100644
--- a/chrome/browser/policy/cloud_policy_validator_unittest.cc
+++ b/chrome/browser/policy/cloud_policy_validator_unittest.cc
@@ -36,7 +36,9 @@ class CloudPolicyValidatorTest : public testing::Test {
         timestamp_(base::Time::UnixEpoch() +
                    base::TimeDelta::FromMilliseconds(
                        PolicyBuilder::kFakeTimestamp)),
-        file_thread_(content::BrowserThread::FILE, &loop_) {}
+        file_thread_(content::BrowserThread::FILE, &loop_) {
+    policy_.set_new_signing_key(PolicyBuilder::CreateTestNewSigningKey());

[pastarmovj, 2012/07/30 12:19:19]

Again I think that tests that don't need special keys e.g. key rotation etc.
will profit from using a hard coded key pair. On my machine ssh-keygen -b 2048
takes around 100ms so this doesn't seem like a premature optimization to me.

[Mattias Nissler (ping if slow), 2012/07/31 13:02:15]

Have you checked PolicyBuilder? This function actually returns a key object
created from static key data :)

+  }
 
   void Validate(testing::Action<void(UserCloudPolicyValidator*)> check_action) {
     std::vector<uint8> public_key;
@@ -50,14 +52,15 @@ class CloudPolicyValidatorTest : public testing::Test {
             policy_.GetCopy(),
             base::Bind(&CloudPolicyValidatorTest::ValidationCompletion,
                        base::Unretained(this)));
-    validator->ValidateTimestamp(timestamp_, timestamp_);
+    validator->ValidateTimestamp(timestamp_, timestamp_, false);

[pastarmovj, 2012/07/30 12:19:19]

Given that we have some more degrees of freedom now it seems that maybe there is
more to be tested here now, namely the cross product of the two new flags.

[Mattias Nissler (ping if slow), 2012/07/31 13:02:15]

Done.

     validator->ValidateUsername(PolicyBuilder::kFakeUsername);
     validator->ValidateDomain(PolicyBuilder::kFakeDomain);
     validator->ValidateDMToken(PolicyBuilder::kFakeToken);
     validator->ValidatePolicyType(dm_protocol::kChromeUserPolicyType);
     validator->ValidatePayload();
     validator->ValidateSignature(std::string(public_key.begin(),
-                                             public_key.end()));
+                                             public_key.end()),
+                                 true);
     validator->ValidateInitialKey();
 
     // Run validation and check the result.