Issue 10828007: Create Tooltip object lazily so that it gets proper drop shadow

Issue 10828007: Create Tooltip object lazily so that it gets proper drop shadow (Closed)

Created:
8 years, 5 months ago by oshima

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, varunjain

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Create Tooltip object lazily so that it gets proper drop shadow AND the TooltipController can be added to all root windows. BUG=138870 TEST=manual. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148378

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : addressed comment #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -24 lines)			Patch
M	ash/shell.cc	View	1 2	3 chunks	+5 lines, -7 lines	0 comments	Download
M	ash/tooltips/tooltip_controller.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ash/tooltips/tooltip_controller.cc	View	1 2 3	10 chunks	+22 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10828007/diff/5001/ash/tooltips/tooltip_controller.cc File ash/tooltips/tooltip_controller.cc (right): http://codereview.chromium.org/10828007/diff/5001/ash/tooltips/tooltip_controller.cc#newcode200 ash/tooltips/tooltip_controller.cc:200: TooltipController::Tooltip* TooltipController::GetTooltip() { Make position match header.

8 years, 5 months ago (2012-07-25 15:02:43 UTC) #2

oshima

http://codereview.chromium.org/10828007/diff/5001/ash/tooltips/tooltip_controller.cc File ash/tooltips/tooltip_controller.cc (right): http://codereview.chromium.org/10828007/diff/5001/ash/tooltips/tooltip_controller.cc#newcode200 ash/tooltips/tooltip_controller.cc:200: TooltipController::Tooltip* TooltipController::GetTooltip() { On 2012/07/25 15:02:43, sky wrote: > ...

8 years, 5 months ago (2012-07-25 15:17:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10828007/3002

8 years, 5 months ago (2012-07-25 15:18:22 UTC) #4

Change committed as 148378

Expand Messages | Collapse Messages