Fixes cloud-printer being treated as local-printer problem.

chrome/browser/resources/print_preview/data/destination_store.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * A data store that stores destinations and dispatches events when the data
    * store changes.
@@ skipping 13 matching lines @@
     this.nativeLayer_ = nativeLayer;
 
     /**
      * Internal backing store for the data store.
      * @type {!Array.<!print_preview.Destination>}
      * @private
      */
     this.destinations_ = [];
 
     /**
-     * Cache used for constant lookup of printers.
+     * Cache used for constant lookup of destinations.
      * @type {object.<string, !print_preview.Destination>}
      * @private
      */
     this.destinationMap_ = {};
 
     /**
      * Currently selected destination.
      * @type {print_preview.Destination}
      * @private
      */
     this.selectedDestination_ = null;
 
     /**
      * Initial destination ID used to auto-select the first inserted destination
      * that matches. If {@code null}, the first destination inserted into the
      * store will be selected.
      * @type {?string}
      * @private
      */
     this.initialDestinationId_ = null;
 
     /**
+     * Whether the initial destination is a local one or not.
+     * @type {boolean}
+     * @private
+     */
+    this.isInitialDestinationLocal_ = true;
+
+    /**
      * Whether the destination store will auto select the destination that
      * matches the initial destination.
      * @type {boolean}
      * @private
      */
     this.isInAutoSelectMode_ = false;
 
     /**
      * Event tracker used to track event listeners of the destination store.
      * @type {!EventTracker}
@@ skipping 95 matching lines @@
      */
     get selectedDestination() {
       return this.selectedDestination_;
     },
 
     /**
      * Sets the initially selected destination. If any inserted destinations
      * match this ID, that destination will be automatically selected. This
      * occurs only once for every time this setter is called or if the store is
      * cleared.
-     * @param {?string} ID of the destination that should be selected
-     *     automatically when added to the store or {@code null} if the first
-     *     destination that is inserted should be selected.
+     * @param {?string} initialDestinationId ID of the destination that should
+     *     be selected automatically when added to the store or {@code null} if
+     *     the first destination that is inserted should be selected.
+     * @param {boolean} isLocalDestination Whether the initial destination is
+     *     local.
      */
-    setInitialDestinationId: function(initialDestinationId) {
+    setInitialDestinationId: function(
+        initialDestinationId, isLocalDestination) {
       this.initialDestinationId_ = initialDestinationId;
+      this.isInitialDestinationLocal_ = isLocalDestination;
       this.isInAutoSelectMode_ = true;
       if (this.initialDestinationId_ == null) {
         assert(this.destinations_.length > 0,
                'No destinations available to select');
         this.selectDestination(this.destinations_[0]);
       } else {
         var candidate = this.destinationMap_[this.initialDestinationId_];
         if (candidate != null) {
           this.selectDestination(candidate);
-        } else {
-          // Try and fetch the destination
-          // TODO(rltoscano): Since we don't know if the initialDestinationId is
-          // a local printer or a cloud printer, we are going to assume based on
-          // platform. The C++ layer should be modified to return more
-          // information about the initially selected printer so this assumption
-          // does not have to be made. See http://crbug.com/132831.
-          if (!cr.isChromeOS) {
-            this.nativeLayer_.startGetLocalDestinationCapabilities(
-                initialDestinationId);
-          }
+        } else if (!cr.isChromeOS && isLocalDestination) {
+          this.nativeLayer_.startGetLocalDestinationCapabilities(
+              initialDestinationId);
         }
       }
     },
 
     /**
      * Sets the destination store's Google Cloud Print interface.
      * @param {!print_preview.CloudPrintInterface} cloudPrintInterface Interface
      *     to set.
      */
     setCloudPrintInterface: function(cloudPrintInterface) {
       this.cloudPrintInterface_ = cloudPrintInterface;
       this.tracker_.add(
           this.cloudPrintInterface_,
           cloudprint.CloudPrintInterface.EventType.SEARCH_DONE,
           this.onCloudPrintSearchDone_.bind(this));
       this.tracker_.add(
           this.cloudPrintInterface_,
           cloudprint.CloudPrintInterface.EventType.PRINTER_DONE,
           this.onCloudPrintPrinterDone_.bind(this));
+      this.tracker_.add(
+          this.cloudPrintInterface_,
+          cloudprint.CloudPrintInterface.EventType.PRINTER_FAILED,
+          this.onPrinterFailed_.bind(this));
+      // Fetch initial destination if its a cloud destination.
+      if (this.isInAutoSelectMode_ && !this.isInitialDestinationLocal_) {
+        this.cloudPrintInterface_.printer(this.initialDestinationId_);
+      }
     },
 
     /** @param {!print_preview.Destination} Destination to select. */
     selectDestination: function(destination) {
       this.selectedDestination_ = destination;
       this.selectedDestination_.isRecent = true;
       this.isInAutoSelectMode_ = false;
       if (this.autoSelectTimeout_ != null) {
         clearTimeout(this.autoSelectTimeout_);
         this.autoSelectTimeout_ = null;
@@ skipping 144 matching lines @@
       this.tracker_.add(
           this.nativeLayer_,
           print_preview.NativeLayer.EventType.LOCAL_DESTINATIONS_SET,
           this.onLocalDestinationsSet_.bind(this));
       this.tracker_.add(
           this.nativeLayer_,
           print_preview.NativeLayer.EventType.CAPABILITIES_SET,
           this.onLocalDestinationCapabilitiesSet_.bind(this));
       this.tracker_.add(
           this.nativeLayer_,
+          print_preview.NativeLayer.EventType.GET_CAPABILITIES_FAIL,
+          this.onGetCapabilitiesFail_.bind(this));
+      this.tracker_.add(
+          this.nativeLayer_,
           print_preview.NativeLayer.EventType.DESTINATIONS_RELOAD,
           this.onDestinationsReload_.bind(this));
     },
 
     /**
      * Resets the state of the destination store to its initial state.
      * @private
      */
     reset_: function() {
       this.destinations_ = [];
@@ skipping 46 matching lines @@
         // the same as "printerName". We should include the "printerName" in the
         // response. See http://crbug.com/132831.
         destination = print_preview.LocalDestinationParser.parse(
             {deviceName: destinationId, printerName: destinationId});
         destination.capabilities = capabilities;
         this.insertDestination(destination);
       }
     },
 
     /**
-     * Called when the /search call completes. Adds the fetched printers to the
-     * destination store.
-     * @param {cr.Event} event Contains the fetched printers.
+     * Called when a request to get a local destination's print capabilities
+     * fails. TODO(rltoscano)

[Albert Bodenhamer, 2012/08/24 16:07:26]

TODO, what?

[Robert Toscano, 2012/08/24 17:27:49]

Whoops, it was just a TODO to finish writing the JSDoc comment. Done.

+     */
+    onGetCapabilitiesFail_: function(event) {
+      console.error('Failed to get print capabilities for printer ' +
+                    event.destinationId);
+      if (this.isInAutoSelectMode_ &&
+          this.initialDestinationId_ == event.destinationId) {
+        assert(this.destinations_.length > 0,
+               'No destinations were loaded when failed to get initial ' +
+               'destination');
+        this.selectDestination(this.destinations_[0]);
+      }
+    },
+
+    /**
+     * Called when the /search call completes. Adds the fetched destinations to
+     * the destination store.
+     * @param {cr.Event} event Contains the fetched destinations.
      * @private
      */
     onCloudPrintSearchDone_: function(event) {
       this.insertDestinations(event.printers);
     },
 
     /**
      * Called when /printer call completes. Updates the specified destination's
      * print capabilities.
      * @param {cr.Event} event Contains detailed information about the
@@ skipping 25 matching lines @@
     /**
      * Called when no destination was auto-selected after some timeout. Selects
      * the first destination in store.
      * @private
      */
     onAutoSelectTimeoutExpired_: function() {
       this.autoSelectTimeout_ = null;
       assert(this.destinations_.length > 0,
              'No destinations were loaded before auto-select timeout expired');
       this.selectDestination(this.destinations_[0]);
+    },
+
+    /**
+     * Called when the Google Cloud Print interface fails to lookup a
+     * destination. Selects another destination if the failed destination was
+     * the initial destination.
+     * @param {object} event Contains the ID of the destination that was failed
+     *     to be looked up.
+     * @private
+     */
+    onPrinterFailed_: function(event) {
+      if (event.errorCode == '111' &&
+          this.isInAutoSelectMode_ &&
+          this.initialDestinationId_ == event.destinationId) {
+        console.error('Could not find initial printer: ' + event.destinationId);
+        assert(this.destinations_.length > 0,
+               'No destinations were loaded when failed to get initial ' +
+               'destination');
+        this.selectDestination(this.destinations_[0]);
+      }
     }
   };
 
   // Export
   return {
     DestinationStore: DestinationStore
   };
 });